[Python-checkins] cpython (merge 3.3 -> default): Minor clean-up of function parameters in random().
raymond.hettinger
python-checkins at python.org
Sun Oct 6 06:52:19 CEST 2013
http://hg.python.org/cpython/rev/8494d2c8ef54
changeset: 85989:8494d2c8ef54
parent: 85986:94246efe2275
parent: 85988:0899960835f5
user: Raymond Hettinger <python at rcn.com>
date: Sat Oct 05 21:52:06 2013 -0700
summary:
Minor clean-up of function parameters in random().
files:
Lib/random.py | 29 +++++++++++++++++------------
1 files changed, 17 insertions(+), 12 deletions(-)
diff --git a/Lib/random.py b/Lib/random.py
--- a/Lib/random.py
+++ b/Lib/random.py
@@ -165,18 +165,17 @@
## -------------------- integer methods -------------------
- def randrange(self, start, stop=None, step=1, int=int):
+ def randrange(self, start, stop=None, step=1, _int=int):
"""Choose a random item from range(start, stop[, step]).
This fixes the problem with randint() which includes the
endpoint; in Python this is usually not what you want.
- Do not supply the 'int' argument.
"""
# This code is a bit messy to make it fast for the
# common case while still doing adequate error checking.
- istart = int(start)
+ istart = _int(start)
if istart != start:
raise ValueError("non-integer arg 1 for randrange()")
if stop is None:
@@ -185,7 +184,7 @@
raise ValueError("empty range for randrange()")
# stop argument supplied.
- istop = int(stop)
+ istop = _int(stop)
if istop != stop:
raise ValueError("non-integer stop for randrange()")
width = istop - istart
@@ -195,7 +194,7 @@
raise ValueError("empty range for randrange() (%d,%d, %d)" % (istart, istop, width))
# Non-unit step argument supplied.
- istep = int(step)
+ istep = _int(step)
if istep != step:
raise ValueError("non-integer step for randrange()")
if istep > 0:
@@ -254,21 +253,27 @@
raise IndexError('Cannot choose from an empty sequence')
return seq[i]
- def shuffle(self, x, random=None, int=int):
+ def shuffle(self, x, random=None):
"""Shuffle list x in place, and return None.
Optional argument random is a 0-argument function returning a
random float in [0.0, 1.0); if it is the default None, the
standard random.random will be used.
- Do not supply the 'int' argument.
"""
- randbelow = self._randbelow
- for i in reversed(range(1, len(x))):
- # pick an element in x[:i+1] with which to exchange x[i]
- j = randbelow(i+1) if random is None else int(random() * (i+1))
- x[i], x[j] = x[j], x[i]
+ if random is None:
+ randbelow = self._randbelow
+ for i in reversed(range(1, len(x))):
+ # pick an element in x[:i+1] with which to exchange x[i]
+ j = randbelow(i+1)
+ x[i], x[j] = x[j], x[i]
+ else:
+ _int = int
+ for i in reversed(range(1, len(x))):
+ # pick an element in x[:i+1] with which to exchange x[i]
+ j = _int(random() * (i+1))
+ x[i], x[j] = x[j], x[i]
def sample(self, population, k):
"""Chooses k unique random elements from a population sequence or set.
--
Repository URL: http://hg.python.org/cpython
More information about the Python-checkins
mailing list