[Python-checkins] cpython: Issue #19636: Fix posix__getvolumepathname(), raise an OverflowError if
victor.stinner
python-checkins at python.org
Sun Nov 24 19:23:52 CET 2013
http://hg.python.org/cpython/rev/b3eb42a657a3
changeset: 87515:b3eb42a657a3
user: Victor Stinner <victor.stinner at gmail.com>
date: Sun Nov 24 19:22:57 2013 +0100
summary:
Issue #19636: Fix posix__getvolumepathname(), raise an OverflowError if
the length doesn't fit in an DWORD
files:
Modules/posixmodule.c | 19 ++++++++++++++-----
1 files changed, 14 insertions(+), 5 deletions(-)
diff --git a/Modules/posixmodule.c b/Modules/posixmodule.c
--- a/Modules/posixmodule.c
+++ b/Modules/posixmodule.c
@@ -385,6 +385,8 @@
#endif
#endif
+#define DWORD_MAX 4294967295U
+
#ifdef MS_WINDOWS
static int
@@ -4039,24 +4041,31 @@
{
PyObject *po, *result;
wchar_t *path, *mountpath=NULL;
- size_t bufsize;
+ size_t buflen;
BOOL ret;
if (!PyArg_ParseTuple(args, "U|:_getvolumepathname", &po))
return NULL;
- path = PyUnicode_AsUnicode(po);
+ path = PyUnicode_AsUnicodeAndSize(po, &buflen);
if (path == NULL)
return NULL;
+ buflen += 1;
/* Volume path should be shorter than entire path */
- bufsize = max(MAX_PATH, wcslen(path) * 2 * sizeof(wchar_t)+1);
- mountpath = (wchar_t *)PyMem_Malloc(bufsize);
+ buflen = Py_MAX(buflen, MAX_PATH);
+
+ if (buflen > DWORD_MAX) {
+ PyErr_SetString(PyExc_OverflowError, "path too long");
+ return NULL;
+ }
+
+ mountpath = (wchar_t *)PyMem_Malloc(buflen * sizeof(wchar_t));
if (mountpath == NULL)
return PyErr_NoMemory();
Py_BEGIN_ALLOW_THREADS
ret = GetVolumePathNameW(path, mountpath,
- Py_SAFE_DOWNCAST(bufsize, size_t, DWORD));
+ Py_SAFE_DOWNCAST(buflen, size_t, DWORD));
Py_END_ALLOW_THREADS
if (!ret) {
--
Repository URL: http://hg.python.org/cpython
More information about the Python-checkins
mailing list