[Python-checkins] cpython (3.3): Issue #19523: Closed FileHandler leak which occurred when delay was set.

[vinay.sajip]

http://hg.python.org/cpython/rev/058810fe1b98
changeset:   87121:058810fe1b98
branch:      3.3
parent:      87117:8bbd215940f1
user:        Vinay Sajip <vinay_sajip at yahoo.co.uk>
date:        Fri Nov 15 20:40:27 2013 +0000
summary:
  Issue #19523: Closed FileHandler leak which occurred when delay was set.

files:
  Lib/logging/__init__.py |  4 +++-
  Misc/NEWS               |  2 ++
  2 files changed, 5 insertions(+), 1 deletions(-)


diff --git a/Lib/logging/__init__.py b/Lib/logging/__init__.py
--- a/Lib/logging/__init__.py
+++ b/Lib/logging/__init__.py
@@ -976,8 +976,10 @@
                 self.flush()
                 if hasattr(self.stream, "close"):
                     self.stream.close()
-                StreamHandler.close(self)
                 self.stream = None
+            # Issue #19523: call unconditionally to
+            # prevent a handler leak when delay is set
+            StreamHandler.close(self)
         finally:
             self.release()
 
diff --git a/Misc/NEWS b/Misc/NEWS
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -13,6 +13,8 @@
 Library
 -------
 
+- Issue #19523: Closed FileHandler leak which occurred when delay was set.
+
 - Issue #13674: Prevented time.strftime from crashing on Windows when given
   a year before 1900 and a format of %y.
 

-- 
Repository URL: http://hg.python.org/cpython