[Python-checkins] cpython: Cleanup more old ET library leftovers

eli.bendersky python-checkins at python.org
Sun May 19 18:24:52 CEST 2013


http://hg.python.org/cpython/rev/7e0447ce6689
changeset:   83846:7e0447ce6689
user:        Eli Bendersky <eliben at gmail.com>
date:        Sun May 19 09:24:43 2013 -0700
summary:
  Cleanup more old ET library leftovers

files:
  Lib/test/test_xml_etree.py   |  12 +-----------
  Lib/xml/etree/ElementTree.py |  11 ++++-------
  2 files changed, 5 insertions(+), 18 deletions(-)


diff --git a/Lib/test/test_xml_etree.py b/Lib/test/test_xml_etree.py
--- a/Lib/test/test_xml_etree.py
+++ b/Lib/test/test_xml_etree.py
@@ -240,7 +240,6 @@
 
         self.assertEqual(ET.XML, ET.fromstring)
         self.assertEqual(ET.PI, ET.ProcessingInstruction)
-        self.assertEqual(ET.XMLParser, ET.XMLTreeBuilder)
 
     def test_simpleops(self):
         # Basic method sanity checks.
@@ -433,15 +432,6 @@
                 '   <empty-element />\n'
                 '</root>')
 
-        parser = ET.XMLTreeBuilder() # 1.2 compatibility
-        parser.feed(data)
-        self.serialize_check(parser.close(),
-                '<root>\n'
-                '   <element key="value">text</element>\n'
-                '   <element>text</element>tail\n'
-                '   <empty-element />\n'
-                '</root>')
-
         target = ET.TreeBuilder()
         parser = ET.XMLParser(target=target)
         parser.feed(data)
@@ -1407,7 +1397,7 @@
         # Don't crash when using custom entities.
 
         ENTITIES = {'rsquo': '\u2019', 'lsquo': '\u2018'}
-        parser = ET.XMLTreeBuilder()
+        parser = ET.XMLParser()
         parser.entity.update(ENTITIES)
         parser.feed("""<?xml version="1.0" encoding="UTF-8"?>
 <!DOCTYPE patent-application-publication SYSTEM "pap-v15-2001-01-31.dtd" []>
diff --git a/Lib/xml/etree/ElementTree.py b/Lib/xml/etree/ElementTree.py
--- a/Lib/xml/etree/ElementTree.py
+++ b/Lib/xml/etree/ElementTree.py
@@ -85,7 +85,7 @@
     "TreeBuilder",
     "VERSION",
     "XML", "XMLID",
-    "XMLParser", "XMLTreeBuilder",
+    "XMLParser",
     "register_namespace",
     ]
 
@@ -1654,9 +1654,7 @@
 
     # Element, SubElement, ParseError, TreeBuilder, XMLParser
     from _elementtree import *
-except ImportError:
-    pass
-else:
+
     # Overwrite 'ElementTree.parse' to use the C XMLParser
     class ElementTree(ElementTree):
         __doc__ = ElementTree.__doc__
@@ -1681,11 +1679,10 @@
             finally:
                 if close_source:
                     source.close()
+except ImportError:
+    pass
 
 
-# compatibility
-XMLTreeBuilder = XMLParser
-
 # workaround circular import.
 try:
     from ElementC14N import _serialize_c14n

-- 
Repository URL: http://hg.python.org/cpython


More information about the Python-checkins mailing list