[Python-checkins] cpython (3.3): #17526: fix an IndexError raised while passing code without filename to

ezio.melotti python-checkins at python.org
Sat Mar 30 04:19:39 CET 2013


http://hg.python.org/cpython/rev/39e103c1577e
changeset:   83008:39e103c1577e
branch:      3.3
parent:      83004:f668d2267303
user:        Ezio Melotti <ezio.melotti at gmail.com>
date:        Sat Mar 30 05:17:24 2013 +0200
summary:
  #17526: fix an IndexError raised while passing code without filename to inspect.findsource().  Initial patch by Tyler Doyle.

files:
  Lib/inspect.py           |   2 +-
  Lib/test/test_inspect.py |   6 ++++++
  Misc/NEWS                |  11 +++++++++++
  3 files changed, 18 insertions(+), 1 deletions(-)


diff --git a/Lib/inspect.py b/Lib/inspect.py
--- a/Lib/inspect.py
+++ b/Lib/inspect.py
@@ -550,7 +550,7 @@
 
     file = getfile(object)
     sourcefile = getsourcefile(object)
-    if not sourcefile and file[0] + file[-1] != '<>':
+    if not sourcefile and file[:1] + file[-1:] != '<>':
         raise IOError('source code not available')
     file = sourcefile if sourcefile else file
 
diff --git a/Lib/test/test_inspect.py b/Lib/test/test_inspect.py
--- a/Lib/test/test_inspect.py
+++ b/Lib/test/test_inspect.py
@@ -416,6 +416,12 @@
         finally:
             del linecache.cache[co.co_filename]
 
+    def test_findsource_without_filename(self):
+        for fname in ['', '<string>']:
+            co = compile('x=1', fname, "exec")
+            self.assertRaises(IOError, inspect.findsource, co)
+            self.assertRaises(IOError, inspect.getsource, co)
+
 class TestNoEOL(GetSourceBase):
     def __init__(self, *args, **kwargs):
         self.tempdir = TESTFN + '_dir'
diff --git a/Misc/NEWS b/Misc/NEWS
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -5,8 +5,19 @@
 What's New in Python 3.3.2?
 ===========================
 
+*Release date: XXXX-XX-XX*
+
 *Not yet released, see sections below for changes released in 3.3.0*
 
+Core and Builtins
+-----------------
+
+Library
+-------
+
+- Issue #17526: fix an IndexError raised while passing code without filename to
+  inspect.findsource().  Initial patch by Tyler Doyle.
+
 
 What's New in Python 3.3.1?
 ===========================

-- 
Repository URL: http://hg.python.org/cpython


More information about the Python-checkins mailing list