[Python-checkins] cpython (2.7): #17564: skip test_bad_address unless the tests are run with -unetwork/-uall.

ezio.melotti python-checkins at python.org
Sat Mar 30 00:33:00 CET 2013


http://hg.python.org/cpython/rev/a472fece6f31
changeset:   83005:a472fece6f31
branch:      2.7
parent:      82996:80d7545594ca
user:        Ezio Melotti <ezio.melotti at gmail.com>
date:        Sat Mar 30 01:32:45 2013 +0200
summary:
  #17564: skip test_bad_address unless the tests are run with -unetwork/-uall.

files:
  Lib/test/test_urllib2_localnet.py |  5 +++++
  1 files changed, 5 insertions(+), 0 deletions(-)


diff --git a/Lib/test/test_urllib2_localnet.py b/Lib/test/test_urllib2_localnet.py
--- a/Lib/test/test_urllib2_localnet.py
+++ b/Lib/test/test_urllib2_localnet.py
@@ -489,6 +489,11 @@
     def test_bad_address(self):
         # Make sure proper exception is raised when connecting to a bogus
         # address.
+
+        # as indicated by the comment below, this might fail with some ISP,
+        # so we run the test only when -unetwork/-uall is specified to
+        # mitigate the problem a bit (see #17564)
+        test_support.requires('network')
         self.assertRaises(IOError,
                           # Given that both VeriSign and various ISPs have in
                           # the past or are presently hijacking various invalid

-- 
Repository URL: http://hg.python.org/cpython


More information about the Python-checkins mailing list