[Python-checkins] cpython: Fix test_socket broken in previous commit (changeset 13e2e44db99d).

serhiy.storchaka python-checkins at python.org
Tue Jan 15 10:09:34 CET 2013


http://hg.python.org/cpython/rev/525407d89277
changeset:   81510:525407d89277
user:        Serhiy Storchaka <storchaka at gmail.com>
date:        Tue Jan 15 11:08:30 2013 +0200
summary:
  Fix test_socket broken in previous commit (changeset 13e2e44db99d).
Added new checks for socket.setblocking().

files:
  Lib/test/test_socket.py |  12 +++++++-----
  1 files changed, 7 insertions(+), 5 deletions(-)


diff --git a/Lib/test/test_socket.py b/Lib/test/test_socket.py
--- a/Lib/test/test_socket.py
+++ b/Lib/test/test_socket.py
@@ -3566,7 +3566,10 @@
 
     def testSetBlocking(self):
         # Testing whether set blocking works
-        self.serv.setblocking(0)
+        self.serv.setblocking(True)
+        self.assertIsNone(self.serv.gettimeout())
+        self.serv.setblocking(False)
+        self.assertEqual(self.serv.gettimeout(), 0.0)
         start = time.time()
         try:
             self.serv.accept()
@@ -3575,10 +3578,9 @@
         end = time.time()
         self.assertTrue((end - start) < 1.0, "Error setting non-blocking mode.")
         # Issue 15989
-        self.assertRaises(OverflowError, self.serv.setblocking,
-                          _testcapi.INT_MAX + 1)
-        self.assertRaises(OverflowError, self.serv.setblocking,
-                          _testcapi.UINT_MAX + 1)
+        if _testcapi.UINT_MAX < _testcapi.ULONG_MAX:
+            self.serv.setblocking(_testcapi.UINT_MAX + 1)
+            self.assertIsNone(self.serv.gettimeout())
 
     def _testSetBlocking(self):
         pass

-- 
Repository URL: http://hg.python.org/cpython


More information about the Python-checkins mailing list