[Python-checkins] cpython (3.3): #18453: fix unused variables in test_xmlrpc. Patch by Vajrasky Kok.

ezio.melotti python-checkins at python.org
Sat Aug 10 17:37:57 CEST 2013


http://hg.python.org/cpython/rev/28c756093a63
changeset:   85090:28c756093a63
branch:      3.3
parent:      85088:4daa18b5ad49
user:        Ezio Melotti <ezio.melotti at gmail.com>
date:        Sat Aug 10 18:37:05 2013 +0300
summary:
  #18453: fix unused variables in test_xmlrpc.  Patch by Vajrasky Kok.

files:
  Lib/test/test_xmlrpc.py |  12 ++++++++++--
  1 files changed, 10 insertions(+), 2 deletions(-)


diff --git a/Lib/test/test_xmlrpc.py b/Lib/test/test_xmlrpc.py
--- a/Lib/test/test_xmlrpc.py
+++ b/Lib/test/test_xmlrpc.py
@@ -3,6 +3,7 @@
 import sys
 import time
 import unittest
+from unittest import mock
 import xmlrpc.client as xmlrpclib
 import xmlrpc.server
 import http.client
@@ -249,7 +250,14 @@
 
 class DateTimeTestCase(unittest.TestCase):
     def test_default(self):
-        t = xmlrpclib.DateTime()
+        with mock.patch('time.localtime') as localtime_mock:
+            time_struct = time.struct_time(
+                [2013, 7, 15, 0, 24, 49, 0, 196, 0])
+            localtime_mock.return_value = time_struct
+            localtime = time.localtime()
+            t = xmlrpclib.DateTime()
+            self.assertEqual(str(t),
+                             time.strftime("%Y%m%dT%H:%M:%S", localtime))
 
     def test_time(self):
         d = 1181399930.036952
@@ -286,7 +294,7 @@
         self.assertEqual(t1, tref)
 
         t2 = xmlrpclib._datetime(d)
-        self.assertEqual(t1, tref)
+        self.assertEqual(t2, tref)
 
     def test_comparison(self):
         now = datetime.datetime.now()

-- 
Repository URL: http://hg.python.org/cpython


More information about the Python-checkins mailing list