[Python-checkins] cpython: Issue #16141: replaced old-style exception handling code in logging with the

[vinay.sajip]

http://hg.python.org/cpython/rev/46889b772442
changeset:   79606:46889b772442
parent:      79604:91d4593ac974
user:        Vinay Sajip <vinay_sajip at yahoo.co.uk>
date:        Tue Oct 09 08:06:13 2012 +0100
summary:
  Issue #16141: replaced old-style exception handling code in logging with the modern idiom.

files:
  Lib/logging/__init__.py |   8 +++-----
  Lib/logging/config.py   |   6 ++----
  Lib/logging/handlers.py |  28 +++++++---------------------
  3 files changed, 12 insertions(+), 30 deletions(-)


diff --git a/Lib/logging/__init__.py b/Lib/logging/__init__.py
--- a/Lib/logging/__init__.py
+++ b/Lib/logging/__init__.py
@@ -67,7 +67,7 @@
         """Return the frame object for the caller's stack frame."""
         try:
             raise Exception
-        except:
+        except Exception:
             return sys.exc_info()[2].tb_frame.f_back
 
 # _srcfile is only used in conjunction with sys._getframe().
@@ -938,9 +938,7 @@
             stream.write(msg)
             stream.write(self.terminator)
             self.flush()
-        except (KeyboardInterrupt, SystemExit): #pragma: no cover
-            raise
-        except:
+        except Exception:
             self.handleError(record)
 
 class FileHandler(StreamHandler):
@@ -1837,7 +1835,7 @@
                     pass
                 finally:
                     h.release()
-        except:
+        except: # ignore everything, as we're shutting down
             if raiseExceptions:
                 raise
             #else, swallow
diff --git a/Lib/logging/config.py b/Lib/logging/config.py
--- a/Lib/logging/config.py
+++ b/Lib/logging/config.py
@@ -827,15 +827,13 @@
                             d =json.loads(chunk)
                             assert isinstance(d, dict)
                             dictConfig(d)
-                        except:
+                        except Exception:
                             #Apply new configuration.
 
                             file = io.StringIO(chunk)
                             try:
                                 fileConfig(file)
-                            except (KeyboardInterrupt, SystemExit): #pragma: no cover
-                                raise
-                            except:
+                            except Exception:
                                 traceback.print_exc()
                     if self.server.ready:
                         self.server.ready.set()
diff --git a/Lib/logging/handlers.py b/Lib/logging/handlers.py
--- a/Lib/logging/handlers.py
+++ b/Lib/logging/handlers.py
@@ -72,9 +72,7 @@
             if self.shouldRollover(record):
                 self.doRollover()
             logging.FileHandler.emit(self, record)
-        except (KeyboardInterrupt, SystemExit): #pragma: no cover
-            raise
-        except:
+        except Exception:
             self.handleError(record)
 
     def rotation_filename(self, default_name):
@@ -609,9 +607,7 @@
         try:
             s = self.makePickle(record)
             self.send(s)
-        except (KeyboardInterrupt, SystemExit): #pragma: no cover
-            raise
-        except:
+        except Exception:
             self.handleError(record)
 
     def close(self):
@@ -877,9 +873,7 @@
                 self.socket.sendto(msg, self.address)
             else:
                 self.socket.sendall(msg)
-        except (KeyboardInterrupt, SystemExit): #pragma: no cover
-            raise
-        except:
+        except Exception:
             self.handleError(record)
 
 class SMTPHandler(logging.Handler):
@@ -957,9 +951,7 @@
                 smtp.login(self.username, self.password)
             smtp.sendmail(self.fromaddr, self.toaddrs, msg)
             smtp.quit()
-        except (KeyboardInterrupt, SystemExit): #pragma: no cover
-            raise
-        except:
+        except Exception:
             self.handleError(record)
 
 class NTEventLogHandler(logging.Handler):
@@ -1044,9 +1036,7 @@
                 type = self.getEventType(record)
                 msg = self.format(record)
                 self._welu.ReportEvent(self.appname, id, cat, type, [msg])
-            except (KeyboardInterrupt, SystemExit): #pragma: no cover
-                raise
-            except:
+            except Exception:
                 self.handleError(record)
 
     def close(self):
@@ -1131,9 +1121,7 @@
             if self.method == "POST":
                 h.send(data.encode('utf-8'))
             h.getresponse()    #can't do anything with the result
-        except (KeyboardInterrupt, SystemExit): #pragma: no cover
-            raise
-        except:
+        except Exception:
             self.handleError(record)
 
 class BufferingHandler(logging.Handler):
@@ -1313,9 +1301,7 @@
         """
         try:
             self.enqueue(self.prepare(record))
-        except (KeyboardInterrupt, SystemExit): #pragma: no cover
-            raise
-        except:
+        except Exception:
             self.handleError(record)
 
 if threading:

-- 
Repository URL: http://hg.python.org/cpython