[Python-checkins] cpython (3.2): Issue12510: Attempting to get invalid tooltip no longer closes Idle.

[terry.reedy]

http://hg.python.org/cpython/rev/4a7582866735
changeset:   77195:4a7582866735
branch:      3.2
parent:      77189:6737c2ca98ee
user:        Terry Jan Reedy <tjreedy at udel.edu>
date:        Sun May 27 21:29:17 2012 -0400
summary:
  Issue12510: Attempting to get invalid tooltip no longer closes Idle.
Original patch by Roger Serwy.

files:
  Lib/idlelib/CallTips.py |  9 ++++++---
  Misc/NEWS               |  3 +++
  2 files changed, 9 insertions(+), 3 deletions(-)


diff --git a/Lib/idlelib/CallTips.py b/Lib/idlelib/CallTips.py
--- a/Lib/idlelib/CallTips.py
+++ b/Lib/idlelib/CallTips.py
@@ -110,7 +110,9 @@
             namespace.update(__main__.__dict__)
             try:
                 return eval(name, namespace)
-            except (NameError, AttributeError):
+                # any exception is possible if evalfuncs True in open_calltip
+                # at least Syntax, Name, Attribute, Index, and Key E. if not
+            except:
                 return None
 
 def _find_constructor(class_ob):
@@ -125,9 +127,10 @@
         return None
 
 def get_argspec(ob):
-    """Get a string describing the arguments for the given object."""
+    """Get a string describing the arguments for the given object,
+       only if it is callable."""
     argspec = ""
-    if ob is not None:
+    if ob is not None and hasattr(ob, '__call__'):
         if isinstance(ob, type):
             fob = _find_constructor(ob)
             if fob is None:
diff --git a/Misc/NEWS b/Misc/NEWS
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -67,6 +67,9 @@
 Library
 -------
 
+- Issue12510: Attempting to get invalid tooltip no longer closes Idle.
+  Original patch by Roger Serwy.
+
 - Issue #10365: File open dialog now works instead of crashing
   even when parent window is closed. Patch by Roger Serwy.
 

-- 
Repository URL: http://hg.python.org/cpython