[Python-checkins] cpython: Make test_logging no longer fail if zlib not present. Closes #14256. Patch by
eric.smith
python-checkins at python.org
Mon Mar 12 06:47:34 CET 2012
http://hg.python.org/cpython/rev/4b54a686541f
changeset: 75534:4b54a686541f
parent: 75525:f452d7d5470d
user: Eric V. Smith <eric at trueblade.com>
date: Sun Mar 11 22:46:04 2012 -0700
summary:
Make test_logging no longer fail if zlib not present. Closes #14256. Patch by Pedro Kroger.
files:
Lib/test/test_logging.py | 10 +++++++---
Misc/ACKS | 1 +
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/Lib/test/test_logging.py b/Lib/test/test_logging.py
--- a/Lib/test/test_logging.py
+++ b/Lib/test/test_logging.py
@@ -39,14 +39,13 @@
import struct
import sys
import tempfile
-from test.support import captured_stdout, run_with_locale, run_unittest, patch
-from test.support import TestHandler, Matcher
+from test.support import (captured_stdout, run_with_locale, run_unittest,
+ patch, requires_zlib, TestHandler, Matcher)
import textwrap
import time
import unittest
import warnings
import weakref
-import zlib
try:
import threading
# The following imports are needed only for tests which
@@ -70,6 +69,10 @@
except ImportError:
win32evtlogutil = None
win32evtlog = None
+try:
+ import zlib
+except ImportError:
+ pass
class BaseTest(unittest.TestCase):
@@ -3602,6 +3605,7 @@
self.assertFalse(os.path.exists(namer(self.fn + ".3")))
rh.close()
+ @requires_zlib
def test_rotator(self):
def namer(name):
return name + ".gz"
diff --git a/Misc/ACKS b/Misc/ACKS
--- a/Misc/ACKS
+++ b/Misc/ACKS
@@ -559,6 +559,7 @@
Michael Kremer
Fabian Kreutz
Cédric Krier
+Pedro Kroger
Hannu Krosing
Andrej Krpic
Ivan Krstić
--
Repository URL: http://hg.python.org/cpython
More information about the Python-checkins
mailing list