[Python-checkins] cpython (merge 3.2 -> default): Better diagnose test failure

antoine.pitrou python-checkins at python.org
Fri Jun 29 19:41:59 CEST 2012


http://hg.python.org/cpython/rev/f908faeba369
changeset:   77854:f908faeba369
parent:      77852:23beb7f8561a
parent:      77853:175dab427bfb
user:        Antoine Pitrou <solipsis at pitrou.net>
date:        Fri Jun 29 19:40:54 2012 +0200
summary:
  Better diagnose test failure

files:
  Lib/test/test_threading.py |  4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)


diff --git a/Lib/test/test_threading.py b/Lib/test/test_threading.py
--- a/Lib/test/test_threading.py
+++ b/Lib/test/test_threading.py
@@ -780,10 +780,10 @@
             """
         expected_output = "end of main thread\n"
         p = subprocess.Popen([sys.executable, "-c", script],
-                             stdout=subprocess.PIPE)
+                             stdout=subprocess.PIPE, stderr=subprocess.PIPE)
         stdout, stderr = p.communicate()
         data = stdout.decode().replace('\r', '')
-        self.assertEqual(p.returncode, 0, "Unexpected error")
+        self.assertEqual(p.returncode, 0, "Unexpected error: " + stderr.decode())
         self.assertEqual(data, expected_output)
 
 class LockTests(lock_tests.LockTests):

-- 
Repository URL: http://hg.python.org/cpython


More information about the Python-checkins mailing list