[Python-checkins] cpython (3.2): #12353: argparse now correctly handles null argument values.
r.david.murray
python-checkins at python.org
Sun Jul 22 04:35:29 CEST 2012
http://hg.python.org/cpython/rev/ac53876d1cc8
changeset: 78229:ac53876d1cc8
branch: 3.2
parent: 78226:e7f205ce080e
user: R David Murray <rdmurray at bitdance.com>
date: Sat Jul 21 22:20:11 2012 -0400
summary:
#12353: argparse now correctly handles null argument values.
Patch by Torsten Landschoff.
files:
Lib/argparse.py | 2 +-
Lib/test/test_argparse.py | 1 +
Misc/NEWS | 2 ++
3 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/Lib/argparse.py b/Lib/argparse.py
--- a/Lib/argparse.py
+++ b/Lib/argparse.py
@@ -1976,7 +1976,7 @@
for arg_string in arg_strings:
# for regular arguments, just add them back into the list
- if arg_string[0] not in self.fromfile_prefix_chars:
+ if not arg_string or arg_string[0] not in self.fromfile_prefix_chars:
new_arg_strings.append(arg_string)
# replace arguments referencing files with the file content
diff --git a/Lib/test/test_argparse.py b/Lib/test/test_argparse.py
--- a/Lib/test/test_argparse.py
+++ b/Lib/test/test_argparse.py
@@ -1371,6 +1371,7 @@
('X @hello', NS(a=None, x='X', y=['hello world!'])),
('-a B @recursive Y Z', NS(a='A', x='hello world!', y=['Y', 'Z'])),
('X @recursive Z -a B', NS(a='B', x='X', y=['hello world!', 'Z'])),
+ (["-a", "", "X", "Y"], NS(a='', x='X', y=['Y'])),
]
diff --git a/Misc/NEWS b/Misc/NEWS
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -98,6 +98,8 @@
Library
-------
+- Issue #12353: argparse now correctly handles null argument values.
+
- Issues #10017 and #14998: Fix TypeError using pprint on dictionaries with
user-defined types as keys or other unorderable keys.
--
Repository URL: http://hg.python.org/cpython
More information about the Python-checkins
mailing list