[Python-checkins] cpython (3.2): revert the changes done for issue14826 - quoting witin Request is not desirable.
senthil.kumaran
python-checkins at python.org
Mon Jul 9 02:59:11 CEST 2012
http://hg.python.org/cpython/rev/ebd37273e0fe
changeset: 78017:ebd37273e0fe
branch: 3.2
parent: 78012:ea670d71a36d
user: Senthil Kumaran <senthil at uthcode.com>
date: Sun Jul 08 17:47:25 2012 -0700
summary:
revert the changes done for issue14826 - quoting witin Request is not desirable.
files:
Lib/test/test_urllib.py | 5 -----
Lib/urllib/request.py | 1 -
Misc/NEWS | 5 -----
3 files changed, 0 insertions(+), 11 deletions(-)
diff --git a/Lib/test/test_urllib.py b/Lib/test/test_urllib.py
--- a/Lib/test/test_urllib.py
+++ b/Lib/test/test_urllib.py
@@ -1246,11 +1246,6 @@
# ftp.close()
- def test_quote_url(self):
- Request = urllib.request.Request
- request = Request("http://www.python.org/foo bar")
- self.assertEqual(request.full_url, "http://www.python.org/foo%20bar")
-
def test_main():
support.run_unittest(
diff --git a/Lib/urllib/request.py b/Lib/urllib/request.py
--- a/Lib/urllib/request.py
+++ b/Lib/urllib/request.py
@@ -181,7 +181,6 @@
origin_req_host=None, unverifiable=False):
# unwrap('<URL:type://host/path>') --> 'type://host/path'
self.full_url = unwrap(url)
- self.full_url = quote(self.full_url, safe="%/:=&?~#+!$,;'@()*[]|")
self.full_url, self.fragment = splittag(self.full_url)
self.data = data
self.headers = {}
diff --git a/Misc/NEWS b/Misc/NEWS
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -87,11 +87,6 @@
Library
-------
-- Issue #14826: Quote urls in urllib.request.Request similar to how they are
- quoted by urllib.request.URLopener. Allows urls to spaces in them to work
- transparently with urllib.request.urlopen(...). Patch contributed by Stephen
- Thorne.
-
- Issue #14990: Correctly fail with SyntaxError on invalid encoding
declaration.
--
Repository URL: http://hg.python.org/cpython
More information about the Python-checkins
mailing list