[Python-checkins] devguide: Some advice about what goes into a single commit.

georg.brandl python-checkins at python.org
Fri Jan 13 22:01:19 CET 2012


http://hg.python.org/devguide/rev/2afe1f8ae855
changeset:   474:2afe1f8ae855
user:        Georg Brandl <georg at python.org>
date:        Fri Jan 13 22:01:10 2012 +0100
summary:
  Some advice about what goes into a single commit.

files:
  committing.rst |  10 ++++++++++
  1 files changed, 10 insertions(+), 0 deletions(-)


diff --git a/committing.rst b/committing.rst
--- a/committing.rst
+++ b/committing.rst
@@ -3,6 +3,16 @@
 Committing and Pushing Changes
 ==============================
 
+Once a change patch is ready and tested, it can be committed to the repository.
+We usually prefer to put a whole feature or bugfix into a single commit, but no
+more.  In particular:
+
+* Do **not** fix more than one issue in the same commit (except, of course, if
+  one code change fixes all of them).
+* Do **not** do cosmetic changes to unrelated code in the same commit as some
+  feature/bugfix.
+
+
 Patch Checklist
 ---------------
 

-- 
Repository URL: http://hg.python.org/devguide


More information about the Python-checkins mailing list