[Python-checkins] cpython (3.3): Issue #16752: Add a missing import to modulefinder.

brett.cannon python-checkins at python.org
Sun Dec 23 01:38:42 CET 2012


http://hg.python.org/cpython/rev/1b9b7cb136db
changeset:   80984:1b9b7cb136db
branch:      3.3
parent:      80982:ccc372b37fbb
user:        Brett Cannon <brett at python.org>
date:        Sat Dec 22 19:34:21 2012 -0500
summary:
  Issue #16752: Add a missing import to modulefinder.

Also fix Misc/ACKS to put part of it back in alphabetical order and
remove some duplicate names.

Patch by Berker Peksag.

files:
  Lib/modulefinder.py           |   1 +
  Lib/test/test_modulefinder.py |  15 +++++++++++++++
  Misc/ACKS                     |   4 +---
  Misc/NEWS                     |   2 ++
  4 files changed, 19 insertions(+), 3 deletions(-)


diff --git a/Lib/modulefinder.py b/Lib/modulefinder.py
--- a/Lib/modulefinder.py
+++ b/Lib/modulefinder.py
@@ -2,6 +2,7 @@
 
 import dis
 import imp
+import importlib.machinery
 import marshal
 import os
 import sys
diff --git a/Lib/test/test_modulefinder.py b/Lib/test/test_modulefinder.py
--- a/Lib/test/test_modulefinder.py
+++ b/Lib/test/test_modulefinder.py
@@ -196,6 +196,18 @@
                                 from . import bar
 """]
 
+relative_import_test_4 = [
+    "a.module",
+    ["a", "a.module"],
+    [],
+    [],
+    """\
+a/__init__.py
+                                def foo(): pass
+a/module.py
+                                from . import *
+"""]
+
 
 def open_file(path):
     dirname = os.path.dirname(path)
@@ -273,6 +285,9 @@
     def test_relative_imports_3(self):
         self._do_test(relative_import_test_3)
 
+    def test_relative_imports_4(self):
+        self._do_test(relative_import_test_4)
+
 
 def test_main():
     support.run_unittest(ModuleFinderTest)
diff --git a/Misc/ACKS b/Misc/ACKS
--- a/Misc/ACKS
+++ b/Misc/ACKS
@@ -894,15 +894,13 @@
 William Park
 Harri Pasanen
 Gaël Pasgrimaud
-Berker Peksag
-Bo Peng
-Joe Peterson
 Randy Pausch
 Samuele Pedroni
 Justin Peel
 Marcel van der Peijl
 Berker Peksag
 Steven Pemberton
+Bo Peng
 Santiago Peresón
 George Peristerakis
 Mathieu Perreault
diff --git a/Misc/NEWS b/Misc/NEWS
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -114,6 +114,8 @@
 Library
 -------
 
+- Issue #16752: Add a missing import to modulefinder. Patch by Berker Peksag.
+
 - Issue #16646: ftplib.FTP.makeport() might lose socket error details.
   (patch by Serhiy Storchaka)
 

-- 
Repository URL: http://hg.python.org/cpython


More information about the Python-checkins mailing list