[Python-checkins] cpython (3.2): 3.2 - Fix closes Issue12529 - cgi.parse_header failure on double quotes and

[senthil.kumaran]

http://hg.python.org/cpython/rev/f5bd78b11275
changeset:   72989:f5bd78b11275
branch:      3.2
parent:      72985:e19ccbbe70dd
user:        Senthil Kumaran <senthil at uthcode.com>
date:        Thu Oct 20 01:05:44 2011 +0800
summary:
  3.2 - Fix closes Issue12529 - cgi.parse_header failure on double quotes and
semicolons. Patch by Ben Darnell and Petri Lehtinen.

files:
  Lib/cgi.py           |  2 +-
  Lib/test/test_cgi.py |  4 ++++
  2 files changed, 5 insertions(+), 1 deletions(-)


diff --git a/Lib/cgi.py b/Lib/cgi.py
--- a/Lib/cgi.py
+++ b/Lib/cgi.py
@@ -291,7 +291,7 @@
     while s[:1] == ';':
         s = s[1:]
         end = s.find(';')
-        while end > 0 and s.count('"', 0, end) % 2:
+        while end > 0 and (s.count('"', 0, end) - s.count('\\"', 0, end)) % 2:
             end = s.find(';', end + 1)
         if end < 0:
             end = len(s)
diff --git a/Lib/test/test_cgi.py b/Lib/test/test_cgi.py
--- a/Lib/test/test_cgi.py
+++ b/Lib/test/test_cgi.py
@@ -348,6 +348,10 @@
         self.assertEqual(
             cgi.parse_header('attachment; filename="strange;name";size=123;'),
             ("attachment", {"filename": "strange;name", "size": "123"}))
+        self.assertEqual(
+            cgi.parse_header('form-data; name="files"; filename="fo\\"o;bar"'),
+            ("form-data", {"name": "files", "filename": 'fo"o;bar'}))
+
 
 BOUNDARY = "---------------------------721837373350705526688164684"
 

-- 
Repository URL: http://hg.python.org/cpython