[Python-checkins] cpython: Issue #12045: Avoid duplicate execution of command in ctypes.util._get_soname().

[antoine.pitrou]

http://hg.python.org/cpython/rev/c540b18b00b9
changeset:   70376:c540b18b00b9
user:        Antoine Pitrou <solipsis at pitrou.net>
date:        Wed May 25 18:17:25 2011 +0200
summary:
  Issue #12045: Avoid duplicate execution of command in ctypes.util._get_soname().
Patch by Sijin Joseph.

files:
  Lib/ctypes/util.py |  4 +---
  Misc/NEWS          |  3 +++
  2 files changed, 4 insertions(+), 3 deletions(-)


diff --git a/Lib/ctypes/util.py b/Lib/ctypes/util.py
--- a/Lib/ctypes/util.py
+++ b/Lib/ctypes/util.py
@@ -137,9 +137,7 @@
             rv = f.close()
             if rv == 10:
                 raise OSError('objdump command not found')
-            with contextlib.closing(os.popen(cmd)) as f:
-                data = f.read()
-            res = re.search(r'\sSONAME\s+([^\s]+)', data)
+            res = re.search(r'\sSONAME\s+([^\s]+)', dump)
             if not res:
                 return None
             return res.group(1)
diff --git a/Misc/NEWS b/Misc/NEWS
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -161,6 +161,9 @@
 Library
 -------
 
+- Issue #12045: Avoid duplicate execution of command in ctypes.util._get_soname().
+  Patch by Sijin Joseph.
+
 - Issue #10818: Remove the Tk GUI and the serve() function of the pydoc module,
   pydoc -g has been deprecated in Python 3.2 and it has a new enhanced web
   server.

-- 
Repository URL: http://hg.python.org/cpython