[Python-checkins] #8594: fix ResourceWarning in test_ftplib.py - patch by Nadeem Vawda.

giampaolo.rodola python-checkins at python.org
Tue Mar 8 21:33:32 CET 2011


http://hg.python.org/cpython/rev/7f605fa1688d
changeset:   68332:7f605fa1688d
parent:      68330:fa23f323d747
user:        Giampaolo Rodolà <g.rodola at gmail.com>
date:        Tue Mar 08 21:33:21 2011 +0100
summary:
  #8594: fix ResourceWarning in test_ftplib.py - patch by Nadeem Vawda.

files:
  Lib/test/test_ftplib.py

diff --git a/Lib/test/test_ftplib.py b/Lib/test/test_ftplib.py
--- a/Lib/test/test_ftplib.py
+++ b/Lib/test/test_ftplib.py
@@ -619,8 +619,8 @@
     def test_source_address_passive_connection(self):
         port = support.find_unused_port()
         self.client.source_address = (HOST, port)
-        sock = self.client.transfercmd('list')
-        self.assertEqual(sock.getsockname()[1], port)
+        with self.client.transfercmd('list') as sock:
+            self.assertEqual(sock.getsockname()[1], port)
 
     def test_parse257(self):
         self.assertEqual(ftplib.parse257('257 "/foo/bar"'), '/foo/bar')

-- 
Repository URL: http://hg.python.org/cpython


More information about the Python-checkins mailing list