[Python-checkins] cpython (2.7): merge from 3.2 - Fix closes issue12581 - Increase the urllib.parse test

senthil.kumaran python-checkins at python.org
Sat Jul 23 12:43:10 CEST 2011


http://hg.python.org/cpython/rev/ed79da800b4a
changeset:   71472:ed79da800b4a
branch:      2.7
parent:      71469:a24bd2bf4adb
user:        Senthil Kumaran <senthil at uthcode.com>
date:        Sat Jul 23 18:41:43 2011 +0800
summary:
  merge from 3.2 - Fix closes issue12581 - Increase the urllib.parse test coverage (cases applicable to 2.7). Patch by Petter Haggholm.

files:
  Lib/test/test_urlparse.py |  11 +++++++++--
  1 files changed, 9 insertions(+), 2 deletions(-)


diff --git a/Lib/test/test_urlparse.py b/Lib/test/test_urlparse.py
--- a/Lib/test/test_urlparse.py
+++ b/Lib/test/test_urlparse.py
@@ -82,7 +82,12 @@
     def test_qsl(self):
         for orig, expect in parse_qsl_test_cases:
             result = urlparse.parse_qsl(orig, keep_blank_values=True)
-            self.assertEqual(result, expect, "Error parsing %s" % repr(orig))
+            self.assertEqual(result, expect, "Error parsing %r" % orig)
+            expect_without_blanks = [v for v in expect if len(v[1])]
+            result = urlparse.parse_qsl(orig, keep_blank_values=False)
+            self.assertEqual(result, expect_without_blanks,
+                    "Error parsing %r" % orig)
+
 
     def test_roundtrips(self):
         testcases = [
@@ -331,6 +336,9 @@
         self.checkJoin(SIMPLE_BASE, 'http:?y','http://a/b/c/d?y')
         self.checkJoin(SIMPLE_BASE, 'http:g?y','http://a/b/c/g?y')
         self.checkJoin(SIMPLE_BASE, 'http:g?y/./x','http://a/b/c/g?y/./x')
+        self.checkJoin('http:///', '..','http:///')
+        self.checkJoin('', 'http://a/b/c/g?y/./x','http://a/b/c/g?y/./x')
+        self.checkJoin('', 'http://a/./g', 'http://a/./g')
 
     def test_RFC2732(self):
         for url, hostname, port in [
@@ -505,7 +513,6 @@
         self.assertEqual(urlparse.urlparse("http://www.python.org:80"),
                 ('http','www.python.org:80','','','',''))
 
-
 def test_main():
     test_support.run_unittest(UrlParseTestCase)
 

-- 
Repository URL: http://hg.python.org/cpython


More information about the Python-checkins mailing list