[Python-checkins] cpython (2.7): Avoid failing in test_urllibnet.test_bad_address when some overzealous
antoine.pitrou
python-checkins at python.org
Fri Jul 8 19:15:15 CEST 2011
http://hg.python.org/cpython/rev/3eaf019aa017
changeset: 71257:3eaf019aa017
branch: 2.7
parent: 71249:1ac21a715c5d
user: Antoine Pitrou <solipsis at pitrou.net>
date: Fri Jul 08 19:14:19 2011 +0200
summary:
Avoid failing in test_urllibnet.test_bad_address when some overzealous
DNS service (e.g. OpenDNS) resolves a non-existent domain name. The test
is now skipped instead.
files:
Lib/test/test_urllibnet.py | 8 ++++++++
Misc/NEWS | 4 ++++
2 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/Lib/test/test_urllibnet.py b/Lib/test/test_urllibnet.py
--- a/Lib/test/test_urllibnet.py
+++ b/Lib/test/test_urllibnet.py
@@ -131,6 +131,14 @@
def test_bad_address(self):
# Make sure proper exception is raised when connecting to a bogus
# address.
+ bogus_domain = "sadflkjsasf.i.nvali.d"
+ try:
+ socket.gethostbyname(bogus_domain)
+ except socket.gaierror:
+ pass
+ else:
+ # This happens with some overzealous DNS providers such as OpenDNS
+ self.skipTest("%r should not resolve for test to work" % bogus_domain)
self.assertRaises(IOError,
# SF patch 809915: In Sep 2003, VeriSign started
# highjacking invalid .com and .net addresses to
diff --git a/Misc/NEWS b/Misc/NEWS
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -92,6 +92,10 @@
Tests
-----
+- Avoid failing in test_urllibnet.test_bad_address when some overzealous
+ DNS service (e.g. OpenDNS) resolves a non-existent domain name. The test
+ is now skipped instead.
+
- Issue #8716: Avoid crashes caused by Aqua Tk on OSX when attempting to run
test_tk or test_ttk_guionly under a username that is not currently logged
in to the console windowserver (as may be the case under buildbot or ssh).
--
Repository URL: http://hg.python.org/cpython
More information about the Python-checkins
mailing list