[Python-checkins] cpython (3.2): Issue #12451: xml.dom.pulldom: parse() now opens files in binary mode instead

victor.stinner python-checkins at python.org
Mon Jul 4 01:29:12 CEST 2011


http://hg.python.org/cpython/rev/81424281ee59
changeset:   71162:81424281ee59
branch:      3.2
parent:      71157:419871c62bb3
user:        Victor Stinner <victor.stinner at haypocalc.com>
date:        Mon Jul 04 01:25:55 2011 +0200
summary:
  Issue #12451: xml.dom.pulldom: parse() now opens files in binary mode instead
of the text mode (using the locale encoding) to avoid encoding issues.

files:
  Lib/xml/dom/pulldom.py |  2 +-
  Misc/NEWS              |  3 +++
  2 files changed, 4 insertions(+), 1 deletions(-)


diff --git a/Lib/xml/dom/pulldom.py b/Lib/xml/dom/pulldom.py
--- a/Lib/xml/dom/pulldom.py
+++ b/Lib/xml/dom/pulldom.py
@@ -326,7 +326,7 @@
     if bufsize is None:
         bufsize = default_bufsize
     if isinstance(stream_or_string, str):
-        stream = open(stream_or_string)
+        stream = open(stream_or_string, 'rb')
     else:
         stream = stream_or_string
     if not parser:
diff --git a/Misc/NEWS b/Misc/NEWS
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -19,6 +19,9 @@
 Library
 -------
 
+- Issue #12451: xml.dom.pulldom: parse() now opens files in binary mode instead
+  of the text mode (using the locale encoding) to avoid encoding issues.
+
 C-API
 -----
 

-- 
Repository URL: http://hg.python.org/cpython


More information about the Python-checkins mailing list