[Python-checkins] distutils2: make sure get_last() returns None in case no release matches

tarek.ziade python-checkins at python.org
Sat Jan 1 10:48:12 CET 2011


tarek.ziade pushed 4ee28ba88ed4 to distutils2:

http://hg.python.org/distutils2/rev/4ee28ba88ed4
changeset:   854:4ee28ba88ed4
user:        Tarek Ziade <tarek at ziade.org>
date:        Sat Jan 01 10:13:28 2011 +0100
summary:
  make sure get_last() returns None in case no release matches

files:
  distutils2/index/dist.py
  distutils2/tests/test_index_dist.py

diff --git a/distutils2/index/dist.py b/distutils2/index/dist.py
--- a/distutils2/index/dist.py
+++ b/distutils2/index/dist.py
@@ -376,6 +376,8 @@
         """
         predicate = get_version_predicate(requirements)
         releases = self.filter(predicate)
+        if len(releases) == 0:
+            return None
         releases.sort_releases(prefer_final, reverse=True)
         return releases[0]
 
diff --git a/distutils2/tests/test_index_dist.py b/distutils2/tests/test_index_dist.py
--- a/distutils2/tests/test_index_dist.py
+++ b/distutils2/tests/test_index_dist.py
@@ -237,6 +237,10 @@
 #        dists.sort_distributions(prefer_source=True)
 #        self.assertEqual(fb2_binary, dists[0])
 
+    def test_get_last(self):
+        dists = ReleasesList('Foo')
+        self.assertEqual(dists.get_last('Foo 1.0'), None)
+
 
 def test_suite():
     suite = unittest.TestSuite()

--
Repository URL: http://hg.python.org/distutils2


More information about the Python-checkins mailing list