[Python-checkins] r88337 - in python/branches/py3k: Misc/NEWS Modules/_sqlite/module.c

[brett.cannon]

Author: brett.cannon
Date: Fri Feb  4 21:24:02 2011
New Revision: 88337

Log:
There was a possibility that the initialization of _sqlite, when it failed,
would lead to a decref of a NULL.

Fixes issue #11110.


Modified:
   python/branches/py3k/Misc/NEWS
   python/branches/py3k/Modules/_sqlite/module.c

Modified: python/branches/py3k/Misc/NEWS
==============================================================================
--- python/branches/py3k/Misc/NEWS	(original)
+++ python/branches/py3k/Misc/NEWS	Fri Feb  4 21:24:02 2011
@@ -15,6 +15,8 @@
 Library
 -------
 
+- Issue #11110: Fix a potential decref of a NULL in sqlite3.
+
 - Issue #8275: Fix passing of callback arguments with ctypes under Win64.
   Patch by Stan Mihai.
 

Modified: python/branches/py3k/Modules/_sqlite/module.c
==============================================================================
--- python/branches/py3k/Modules/_sqlite/module.c	(original)
+++ python/branches/py3k/Modules/_sqlite/module.c	Fri Feb  4 21:24:02 2011
@@ -329,7 +329,7 @@
         (pysqlite_statement_setup_types() < 0) ||
         (pysqlite_prepare_protocol_setup_types() < 0)
        ) {
-        Py_DECREF(module);
+        Py_XDECREF(module);
         return NULL;
     }