[Python-checkins] cpython (3.2): Issue #11006: Don't issue low level warning in subprocess when pipe2() fails.

ross.lagerwall python-checkins at python.org
Thu Dec 22 08:21:08 CET 2011


http://hg.python.org/cpython/rev/dc913f73a7fb
changeset:   74125:dc913f73a7fb
branch:      3.2
parent:      74122:8f33758df19a
user:        Ross Lagerwall <rosslagerwall at gmail.com>
date:        Thu Dec 22 09:07:30 2011 +0200
summary:
  Issue #11006: Don't issue low level warning in subprocess when pipe2() fails.

files:
  Misc/NEWS                  |  2 ++
  Modules/_posixsubprocess.c |  6 ------
  2 files changed, 2 insertions(+), 6 deletions(-)


diff --git a/Misc/NEWS b/Misc/NEWS
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -97,6 +97,8 @@
 Library
 -------
 
+- Issue #11006: Don't issue low level warning in subprocess when pipe2() fails.
+
 - Issue #11829: Fix code execution holes in inspect.getattr_static for
   metaclasses with metaclasses. Patch by Andreas Stührk.
 
diff --git a/Modules/_posixsubprocess.c b/Modules/_posixsubprocess.c
--- a/Modules/_posixsubprocess.c
+++ b/Modules/_posixsubprocess.c
@@ -437,12 +437,6 @@
     Py_END_ALLOW_THREADS
     if (res != 0 && errno == ENOSYS)
     {
-        if (PyErr_WarnEx(
-                PyExc_RuntimeWarning,
-                "pipe2 set errno ENOSYS; falling "
-                "back to non-atomic pipe+fcntl.", 1) != 0) {
-            return NULL;
-        }
         {
 #endif
         /* We hold the GIL which offers some protection from other code calling

-- 
Repository URL: http://hg.python.org/cpython


More information about the Python-checkins mailing list