[Python-checkins] r85206 - in python/branches/release31-maint: Lib/http/client.py Lib/test/test_httplib.py
senthil.kumaran
python-checkins at python.org
Sun Oct 3 20:25:01 CEST 2010
Author: senthil.kumaran
Date: Sun Oct 3 20:25:01 2010
New Revision: 85206
Log:
Merged revisions 85205 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k
........
r85205 | senthil.kumaran | 2010-10-03 23:52:42 +0530 (Sun, 03 Oct 2010) | 3 lines
Fix Issue10012 - httplib headers, which are (sometimes mistakenly) int are explicitly cast to str (bytes - in py3k).
........
Modified:
python/branches/release31-maint/ (props changed)
python/branches/release31-maint/Lib/http/client.py
python/branches/release31-maint/Lib/test/test_httplib.py
Modified: python/branches/release31-maint/Lib/http/client.py
==============================================================================
--- python/branches/release31-maint/Lib/http/client.py (original)
+++ python/branches/release31-maint/Lib/http/client.py Sun Oct 3 20:25:01 2010
@@ -916,6 +916,8 @@
for i, one_value in enumerate(values):
if hasattr(one_value, 'encode'):
values[i] = one_value.encode('ascii')
+ elif isinstance(one_value, int):
+ values[i] = str(one_value).encode('ascii')
value = b'\r\n\t'.join(values)
header = header + b': ' + value
self._output(header)
Modified: python/branches/release31-maint/Lib/test/test_httplib.py
==============================================================================
--- python/branches/release31-maint/Lib/test/test_httplib.py (original)
+++ python/branches/release31-maint/Lib/test/test_httplib.py Sun Oct 3 20:25:01 2010
@@ -89,6 +89,15 @@
conn.request('POST', '/', body, headers)
self.assertEqual(conn._buffer.count[header.lower()], 1)
+ def test_putheader(self):
+ conn = client.HTTPConnection('example.com')
+ conn.sock = FakeSocket(None)
+ conn.putrequest('GET','/')
+ conn.putheader('Content-length', 42)
+ print(conn._buffer)
+ self.assertTrue(b'Content-length: 42' in conn._buffer)
+
+
class BasicTest(TestCase):
def test_status_lines(self):
# Test HTTP status lines
More information about the Python-checkins
mailing list