[Python-checkins] r86214 - in python/branches/py3k: Misc/ACKS Misc/NEWS Modules/signalmodule.c
antoine.pitrou
python-checkins at python.org
Fri Nov 5 20:47:27 CET 2010
Author: antoine.pitrou
Date: Fri Nov 5 20:47:27 2010
New Revision: 86214
Log:
Issue #10311: The signal module now restores errno before returning from
its low-level signal handler. Patch by Hallvard B Furuseth.
Modified:
python/branches/py3k/Misc/ACKS
python/branches/py3k/Misc/NEWS
python/branches/py3k/Modules/signalmodule.c
Modified: python/branches/py3k/Misc/ACKS
==============================================================================
--- python/branches/py3k/Misc/ACKS (original)
+++ python/branches/py3k/Misc/ACKS Fri Nov 5 20:47:27 2010
@@ -285,6 +285,7 @@
Geoff Furnish
Ulisses Furquim
Hagen Fürstenau
+Hallvard B Furuseth
Achim Gaedke
Martin von Gagern
Lele Gaifax
Modified: python/branches/py3k/Misc/NEWS
==============================================================================
--- python/branches/py3k/Misc/NEWS (original)
+++ python/branches/py3k/Misc/NEWS Fri Nov 5 20:47:27 2010
@@ -65,6 +65,9 @@
Library
-------
+- Issue #10311: The signal module now restores errno before returning from
+ its low-level signal handler. Patch by Hallvard B Furuseth.
+
- Issue #10282: Add a ``nntp_implementation`` attribute to NNTP objects.
- Issue #10283: Add a ``group_pattern`` argument to NNTP.list().
Modified: python/branches/py3k/Modules/signalmodule.c
==============================================================================
--- python/branches/py3k/Modules/signalmodule.c (original)
+++ python/branches/py3k/Modules/signalmodule.c Fri Nov 5 20:47:27 2010
@@ -169,16 +169,20 @@
static void
signal_handler(int sig_num)
{
-#ifdef WITH_THREAD
-#ifdef WITH_PTH
+ int save_errno = errno;
+
+#if defined(WITH_THREAD) && defined(WITH_PTH)
if (PyThread_get_thread_ident() != main_thread) {
pth_raise(*(pth_t *) main_thread, sig_num);
- return;
}
+ else
#endif
+ {
+#ifdef WITH_THREAD
/* See NOTES section above */
- if (getpid() == main_pid) {
+ if (getpid() == main_pid)
#endif
+ {
Handlers[sig_num].tripped = 1;
/* Set is_tripped after setting .tripped, as it gets
cleared in PyErr_CheckSignals() before .tripped. */
@@ -186,24 +190,26 @@
Py_AddPendingCall(checksignals_witharg, NULL);
if (wakeup_fd != -1)
write(wakeup_fd, "\0", 1);
-#ifdef WITH_THREAD
}
-#endif
+
+#ifndef HAVE_SIGACTION
#ifdef SIGCHLD
- if (sig_num == SIGCHLD) {
- /* To avoid infinite recursion, this signal remains
- reset until explicit re-instated.
- Don't clear the 'func' field as it is our pointer
- to the Python handler... */
- return;
- }
+ /* To avoid infinite recursion, this signal remains
+ reset until explicit re-instated.
+ Don't clear the 'func' field as it is our pointer
+ to the Python handler... */
+ if (sig_num != SIGCHLD)
#endif
-#ifndef HAVE_SIGACTION
/* If the handler was not set up with sigaction, reinstall it. See
* Python/pythonrun.c for the implementation of PyOS_setsig which
* makes this true. See also issue8354. */
PyOS_setsig(sig_num, signal_handler);
#endif
+ }
+
+ /* Issue #10311: asynchronously executing signal handlers should not
+ mutate errno under the feet of unsuspecting C code. */
+ errno = save_errno;
}
More information about the Python-checkins
mailing list