[Python-checkins] r86202 - python/branches/py3k/Lib/test/test_quopri.py

brian.curtin python-checkins at python.org
Fri Nov 5 16:40:28 CET 2010


Author: brian.curtin
Date: Fri Nov  5 16:40:27 2010
New Revision: 86202

Log:
Fix ResourceWarning from subprocess pipes being left open.


Modified:
   python/branches/py3k/Lib/test/test_quopri.py

Modified: python/branches/py3k/Lib/test/test_quopri.py
==============================================================================
--- python/branches/py3k/Lib/test/test_quopri.py	(original)
+++ python/branches/py3k/Lib/test/test_quopri.py	Fri Nov  5 16:40:27 2010
@@ -178,6 +178,7 @@
         (p, e) = self.STRINGS[-1]
         process = subprocess.Popen([sys.executable, "-mquopri"],
                                    stdin=subprocess.PIPE, stdout=subprocess.PIPE)
+        self.addCleanup(process.stdout.close)
         cout, cerr = process.communicate(p)
         # On Windows, Python will output the result to stdout using
         # CRLF, as the mode of stdout is text mode. To compare this
@@ -193,6 +194,7 @@
         (p, e) = self.STRINGS[-1]
         process = subprocess.Popen([sys.executable, "-mquopri", "-d"],
                                    stdin=subprocess.PIPE, stdout=subprocess.PIPE)
+        self.addCleanup(process.stdout.close)
         cout, cerr = process.communicate(e)
         cout = cout.decode('latin-1')
         p = p.decode('latin-1')


More information about the Python-checkins mailing list