[Python-checkins] r81461 - in python/branches/py3k: Lib/codecs.py Lib/test/test_codecs.py Misc/NEWS

[victor.stinner]

Author: victor.stinner
Date: Sat May 22 04:16:27 2010
New Revision: 81461

Log:
Merged revisions 81459 via svnmerge from 
svn+ssh://pythondev@svn.python.org/python/trunk

........
  r81459 | victor.stinner | 2010-05-22 04:11:07 +0200 (sam., 22 mai 2010) | 3 lines
  
  Issue #6268: Fix seek() method of codecs.open(), don't read the BOM twice
  after seek(0)
........


Modified:
   python/branches/py3k/   (props changed)
   python/branches/py3k/Lib/codecs.py
   python/branches/py3k/Lib/test/test_codecs.py
   python/branches/py3k/Misc/NEWS

Modified: python/branches/py3k/Lib/codecs.py
==============================================================================
--- python/branches/py3k/Lib/codecs.py	(original)
+++ python/branches/py3k/Lib/codecs.py	Sat May 22 04:16:27 2010
@@ -699,6 +699,10 @@
         self.reader.reset()
         self.writer.reset()
 
+    def seek(self, offset, whence=0):
+        self.reader.seek(offset, whence)
+        self.writer.seek(offset, whence)
+
     def __getattr__(self, name,
                     getattr=getattr):
 

Modified: python/branches/py3k/Lib/test/test_codecs.py
==============================================================================
--- python/branches/py3k/Lib/test/test_codecs.py	(original)
+++ python/branches/py3k/Lib/test/test_codecs.py	Sat May 22 04:16:27 2010
@@ -1594,6 +1594,26 @@
                          b"\xe4\xeb\xef\xf6\xfc")
 
 
+class BomTest(unittest.TestCase):
+    def test_seek0(self):
+        data = "1234567890"
+        tests = ("utf-16",
+                 "utf-16-le",
+                 "utf-16-be",
+                 "utf-32",
+                 "utf-32-le",
+                 "utf-32-be")
+        for encoding in tests:
+            with codecs.open('foo', 'w+', encoding=encoding) as f:
+                # Check if the BOM is written only once
+                f.write(data)
+                f.write(data)
+                f.seek(0)
+                self.assertEquals(f.read(), data * 2)
+                f.seek(0)
+                self.assertEquals(f.read(), data * 2)
+
+
 def test_main():
     support.run_unittest(
         UTF32Test,
@@ -1621,6 +1641,7 @@
         WithStmtTest,
         TypesTest,
         SurrogateEscapeTest,
+        BomTest,
     )
 
 

Modified: python/branches/py3k/Misc/NEWS
==============================================================================
--- python/branches/py3k/Misc/NEWS	(original)
+++ python/branches/py3k/Misc/NEWS	Sat May 22 04:16:27 2010
@@ -393,6 +393,9 @@
 Library
 -------
 
+- Issue #6268: Fix seek() method of codecs.open(), don't read the BOM twice
+  after seek(0)
+
 - Issue #3798: sys.exit(message) writes the message to sys.stderr file, instead
   of the C file stderr, to use stderr encoding and error handler