[Python-checkins] r81432 - in python/trunk: Lib/linecache.py Lib/test/test_linecache.py Misc/NEWS

[benjamin.peterson]

Author: benjamin.peterson
Date: Fri May 21 23:31:24 2010
New Revision: 81432

Log:
ensure the last line has a trailing newline #8782

Modified:
   python/trunk/Lib/linecache.py
   python/trunk/Lib/test/test_linecache.py
   python/trunk/Misc/NEWS

Modified: python/trunk/Lib/linecache.py
==============================================================================
--- python/trunk/Lib/linecache.py	(original)
+++ python/trunk/Lib/linecache.py	Fri May 21 23:31:24 2010
@@ -133,6 +133,8 @@
     except IOError, msg:
 ##      print '*** Cannot open', fullname, ':', msg
         return []
+    if lines and not lines[-1].endswith('\n'):
+        lines[-1] += '\n'
     size, mtime = stat.st_size, stat.st_mtime
     cache[filename] = size, mtime, lines, fullname
     return lines

Modified: python/trunk/Lib/test/test_linecache.py
==============================================================================
--- python/trunk/Lib/test/test_linecache.py	(original)
+++ python/trunk/Lib/test/test_linecache.py	Fri May 21 23:31:24 2010
@@ -31,6 +31,11 @@
 
 '''
 
+SOURCE_3 = '''
+def f():
+    return 3''' # No ending newline
+
+
 class LineCacheTests(unittest.TestCase):
 
     def test_getline(self):
@@ -63,6 +68,13 @@
         empty = linecache.getlines('a/b/c/__init__.py')
         self.assertEquals(empty, [])
 
+    def test_no_ending_newline(self):
+        self.addCleanup(support.unlink, support.TESTFN)
+        with open(support.TESTFN, "w") as fp:
+            fp.write(SOURCE_3)
+        lines = linecache.getlines(support.TESTFN)
+        self.assertEqual(lines, ["\n", "def f():\n", "    return 3\n"])
+
     def test_clearcache(self):
         cached = []
         for entry in TESTS:

Modified: python/trunk/Misc/NEWS
==============================================================================
--- python/trunk/Misc/NEWS	(original)
+++ python/trunk/Misc/NEWS	Fri May 21 23:31:24 2010
@@ -29,6 +29,9 @@
 Library
 -------
 
+- Issue #8782: Add a trailing newline in linecache.updatecache to the last line
+  of files without one.
+
 - Issue #8729: Return NotImplemented from collections.Mapping.__eq__ when
   comparing to a non-mapping.