[Python-checkins] r79263 - in python/trunk/Lib: test/test_unittest.py unittest/__init__.py unittest/__main__.py unittest/case.py unittest/loader.py unittest/main.py unittest/result.py unittest/runner.py unittest/suite.py unittest/util.py

[michael.foord]

Author: michael.foord
Date: Mon Mar 22 01:06:30 2010
New Revision: 79263

Log:
Issue 7815. __unittest in module globals trims frames from reported stacktraces in unittest.

Modified:
   python/trunk/Lib/test/test_unittest.py
   python/trunk/Lib/unittest/__init__.py
   python/trunk/Lib/unittest/__main__.py
   python/trunk/Lib/unittest/case.py
   python/trunk/Lib/unittest/loader.py
   python/trunk/Lib/unittest/main.py
   python/trunk/Lib/unittest/result.py
   python/trunk/Lib/unittest/runner.py
   python/trunk/Lib/unittest/suite.py
   python/trunk/Lib/unittest/util.py

Modified: python/trunk/Lib/test/test_unittest.py
==============================================================================
--- python/trunk/Lib/test/test_unittest.py	(original)
+++ python/trunk/Lib/test/test_unittest.py	Mon Mar 22 01:06:30 2010
@@ -2084,6 +2084,16 @@
                 'Tests getDescription() for a method with a longer '
                 'docstring.'))
 
+    def testStackFrameTrimming(self):
+        class Frame(object):
+            class tb_frame(object):
+                f_globals = {}
+        result = unittest.TestResult()
+        self.assertFalse(result._is_relevant_tb_level(Frame))
+
+        Frame.tb_frame.f_globals['__unittest'] = True
+        self.assertTrue(result._is_relevant_tb_level(Frame))
+
 classDict = dict(unittest.TestResult.__dict__)
 for m in ('addSkip', 'addExpectedFailure', 'addUnexpectedSuccess',
            '__init__'):

Modified: python/trunk/Lib/unittest/__init__.py
==============================================================================
--- python/trunk/Lib/unittest/__init__.py	(original)
+++ python/trunk/Lib/unittest/__init__.py	Mon Mar 22 01:06:30 2010
@@ -64,3 +64,5 @@
 
 # deprecated
 _TextTestResult = TextTestResult
+
+__unittest = True

Modified: python/trunk/Lib/unittest/__main__.py
==============================================================================
--- python/trunk/Lib/unittest/__main__.py	(original)
+++ python/trunk/Lib/unittest/__main__.py	Mon Mar 22 01:06:30 2010
@@ -4,5 +4,8 @@
 if sys.argv[0].endswith("__main__.py"):
     sys.argv[0] = "unittest"
 
+__unittest = True
+
+
 from .main import main
 main(module=None)

Modified: python/trunk/Lib/unittest/case.py
==============================================================================
--- python/trunk/Lib/unittest/case.py	(original)
+++ python/trunk/Lib/unittest/case.py	Mon Mar 22 01:06:30 2010
@@ -12,6 +12,9 @@
     strclass, safe_repr, sorted_list_difference, unorderable_list_difference
 )
 
+__unittest = True
+
+
 class SkipTest(Exception):
     """
     Raise this exception in a test to skip it.

Modified: python/trunk/Lib/unittest/loader.py
==============================================================================
--- python/trunk/Lib/unittest/loader.py	(original)
+++ python/trunk/Lib/unittest/loader.py	Mon Mar 22 01:06:30 2010
@@ -10,6 +10,8 @@
 
 from . import case, suite
 
+__unittest = True
+
 
 def _CmpToKey(mycmp):
     'Convert a cmp= function into a key= function'

Modified: python/trunk/Lib/unittest/main.py
==============================================================================
--- python/trunk/Lib/unittest/main.py	(original)
+++ python/trunk/Lib/unittest/main.py	Mon Mar 22 01:06:30 2010
@@ -6,6 +6,8 @@
 
 from . import loader, runner
 
+__unittest = True
+
 
 USAGE_AS_MAIN = """\
 Usage: %(progName)s [options] [tests]

Modified: python/trunk/Lib/unittest/result.py
==============================================================================
--- python/trunk/Lib/unittest/result.py	(original)
+++ python/trunk/Lib/unittest/result.py	Mon Mar 22 01:06:30 2010
@@ -4,6 +4,8 @@
 
 from . import util
 
+__unittest = True
+
 
 class TestResult(object):
     """Holder for test result information.
@@ -98,11 +100,7 @@
         return ''.join(traceback.format_exception(exctype, value, tb))
 
     def _is_relevant_tb_level(self, tb):
-        globs = tb.tb_frame.f_globals
-        is_relevant =  '__name__' in globs and \
-            globs["__name__"].startswith("unittest")
-        del globs
-        return is_relevant
+        return '__unittest' in tb.tb_frame.f_globals
 
     def _count_relevant_tb_levels(self, tb):
         length = 0

Modified: python/trunk/Lib/unittest/runner.py
==============================================================================
--- python/trunk/Lib/unittest/runner.py	(original)
+++ python/trunk/Lib/unittest/runner.py	Mon Mar 22 01:06:30 2010
@@ -5,6 +5,8 @@
 
 from . import result
 
+__unittest = True
+
 
 class _WritelnDecorator(object):
     """Used to decorate file-like objects with a handy 'writeln' method"""

Modified: python/trunk/Lib/unittest/suite.py
==============================================================================
--- python/trunk/Lib/unittest/suite.py	(original)
+++ python/trunk/Lib/unittest/suite.py	Mon Mar 22 01:06:30 2010
@@ -5,6 +5,8 @@
 from . import case
 from . import util
 
+__unittest = True
+
 
 class BaseTestSuite(object):
     """A simple test suite that doesn't provide class or module shared fixtures.

Modified: python/trunk/Lib/unittest/util.py
==============================================================================
--- python/trunk/Lib/unittest/util.py	(original)
+++ python/trunk/Lib/unittest/util.py	Mon Mar 22 01:06:30 2010
@@ -1,5 +1,8 @@
 """Various utility functions."""
 
+__unittest = True
+
+
 def safe_repr(obj):
     try:
         return repr(obj)