[Python-checkins] r79199 - in python/branches/release26-maint: Include/pystate.h Misc/NEWS Modules/threadmodule.c Python/pystate.c
victor.stinner
python-checkins at python.org
Sun Mar 21 14:32:32 CET 2010
Author: victor.stinner
Date: Sun Mar 21 14:32:31 2010
New Revision: 79199
Log:
Merged revisions 78638 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/trunk
........
r78638 | victor.stinner | 2010-03-04 00:20:25 +0100 (jeu., 04 mars 2010) | 3 lines
Issue #7544: Preallocate thread memory before creating the thread to avoid a
fatal error in low memory condition.
........
Modified:
python/branches/release26-maint/ (props changed)
python/branches/release26-maint/Include/pystate.h
python/branches/release26-maint/Misc/NEWS
python/branches/release26-maint/Modules/threadmodule.c
python/branches/release26-maint/Python/pystate.c
Modified: python/branches/release26-maint/Include/pystate.h
==============================================================================
--- python/branches/release26-maint/Include/pystate.h (original)
+++ python/branches/release26-maint/Include/pystate.h Sun Mar 21 14:32:31 2010
@@ -105,6 +105,8 @@
PyAPI_FUNC(void) PyInterpreterState_Delete(PyInterpreterState *);
PyAPI_FUNC(PyThreadState *) PyThreadState_New(PyInterpreterState *);
+PyAPI_FUNC(PyThreadState *) _PyThreadState_Prealloc(PyInterpreterState *);
+PyAPI_FUNC(void) _PyThreadState_Init(PyThreadState *);
PyAPI_FUNC(void) PyThreadState_Clear(PyThreadState *);
PyAPI_FUNC(void) PyThreadState_Delete(PyThreadState *);
#ifdef WITH_THREAD
Modified: python/branches/release26-maint/Misc/NEWS
==============================================================================
--- python/branches/release26-maint/Misc/NEWS (original)
+++ python/branches/release26-maint/Misc/NEWS Sun Mar 21 14:32:31 2010
@@ -12,6 +12,9 @@
Core and Builtins
-----------------
+- Issue #7544: Preallocate thread memory before creating the thread to avoid
+ a fatal error in low memory condition.
+
- Issue #7820: The parser tokenizer restores all bytes in the right if
the BOM check fails.
Modified: python/branches/release26-maint/Modules/threadmodule.c
==============================================================================
--- python/branches/release26-maint/Modules/threadmodule.c (original)
+++ python/branches/release26-maint/Modules/threadmodule.c Sun Mar 21 14:32:31 2010
@@ -411,6 +411,7 @@
PyObject *func;
PyObject *args;
PyObject *keyw;
+ PyThreadState *tstate;
};
static void
@@ -420,8 +421,9 @@
PyThreadState *tstate;
PyObject *res;
- tstate = PyThreadState_New(boot->interp);
-
+ tstate = boot->tstate;
+ tstate->thread_id = PyThread_get_thread_ident();
+ _PyThreadState_Init(tstate);
PyEval_AcquireThread(tstate);
res = PyEval_CallObjectWithKeywords(
boot->func, boot->args, boot->keyw);
@@ -484,6 +486,11 @@
boot->func = func;
boot->args = args;
boot->keyw = keyw;
+ boot->tstate = _PyThreadState_Prealloc(boot->interp);
+ if (boot->tstate == NULL) {
+ PyMem_DEL(boot);
+ return PyErr_NoMemory();
+ }
Py_INCREF(func);
Py_INCREF(args);
Py_XINCREF(keyw);
@@ -494,6 +501,7 @@
Py_DECREF(func);
Py_DECREF(args);
Py_XDECREF(keyw);
+ PyThreadState_Clear(boot->tstate);
PyMem_DEL(boot);
return NULL;
}
Modified: python/branches/release26-maint/Python/pystate.c
==============================================================================
--- python/branches/release26-maint/Python/pystate.c (original)
+++ python/branches/release26-maint/Python/pystate.c Sun Mar 21 14:32:31 2010
@@ -154,8 +154,8 @@
return self->frame;
}
-PyThreadState *
-PyThreadState_New(PyInterpreterState *interp)
+static PyThreadState *
+new_threadstate(PyInterpreterState *interp, int init)
{
PyThreadState *tstate = (PyThreadState *)malloc(sizeof(PyThreadState));
@@ -193,9 +193,8 @@
tstate->c_profileobj = NULL;
tstate->c_traceobj = NULL;
-#ifdef WITH_THREAD
- _PyGILState_NoteThreadState(tstate);
-#endif
+ if (init)
+ _PyThreadState_Init(tstate);
HEAD_LOCK();
tstate->next = interp->tstate_head;
@@ -206,6 +205,25 @@
return tstate;
}
+PyThreadState *
+PyThreadState_New(PyInterpreterState *interp)
+{
+ return new_threadstate(interp, 1);
+}
+
+PyThreadState *
+_PyThreadState_Prealloc(PyInterpreterState *interp)
+{
+ return new_threadstate(interp, 0);
+}
+
+void
+_PyThreadState_Init(PyThreadState *tstate)
+{
+#ifdef WITH_THREAD
+ _PyGILState_NoteThreadState(tstate);
+#endif
+}
void
PyThreadState_Clear(PyThreadState *tstate)
More information about the Python-checkins
mailing list