[Python-checkins] r78651 - in python/branches/release26-maint/Lib: test/test_urllib2.py urllib2.py

senthil.kumaran python-checkins at python.org
Thu Mar 4 16:15:38 CET 2010


Author: senthil.kumaran
Date: Thu Mar  4 16:15:37 2010
New Revision: 78651

Log:
Reverting the changes made in r78432. Discussed in the tracker issue7540.



Modified:
   python/branches/release26-maint/Lib/test/test_urllib2.py
   python/branches/release26-maint/Lib/urllib2.py

Modified: python/branches/release26-maint/Lib/test/test_urllib2.py
==============================================================================
--- python/branches/release26-maint/Lib/test/test_urllib2.py	(original)
+++ python/branches/release26-maint/Lib/test/test_urllib2.py	Thu Mar  4 16:15:37 2010
@@ -1209,7 +1209,6 @@
         self.get.add_data("spam")
         self.assert_(self.get.has_data())
         self.assertEqual("POST", self.get.get_method())
-        self.assertRaises(TypeError,self.get.add_data, "more spam")
 
     def test_get_full_url(self):
         self.assertEqual("http://www.python.org/~jeremy/",

Modified: python/branches/release26-maint/Lib/urllib2.py
==============================================================================
--- python/branches/release26-maint/Lib/urllib2.py	(original)
+++ python/branches/release26-maint/Lib/urllib2.py	Thu Mar  4 16:15:37 2010
@@ -226,9 +226,6 @@
     # XXX these helper methods are lame
 
     def add_data(self, data):
-        if self.has_data():
-            raise TypeError("Request Obj already contains data: %s" %
-                            self.data)
         self.data = data
 
     def has_data(self):


More information about the Python-checkins mailing list