[Python-checkins] r81813 - python/trunk/Objects/stringlib/formatter.h

Eric Smith eric at trueblade.com
Tue Jun 8 00:23:45 CEST 2010


String literals already have a trailing zero byte, so now you're wasting 
space!

Maybe a better comment would be in line.

Eric.

benjamin.peterson wrote:
> Author: benjamin.peterson
> Date: Mon Jun  7 23:37:09 2010
> New Revision: 81813
> 
> Log:
> locale grouping strings should end in '\0'
> 
> 
> Modified:
>    python/trunk/Objects/stringlib/formatter.h
> 
> Modified: python/trunk/Objects/stringlib/formatter.h
> ==============================================================================
> --- python/trunk/Objects/stringlib/formatter.h	(original)
> +++ python/trunk/Objects/stringlib/formatter.h	Mon Jun  7 23:37:09 2010
> @@ -649,7 +649,7 @@
>      case LT_DEFAULT_LOCALE:
>          locale_info->decimal_point = ".";
>          locale_info->thousands_sep = ",";
> -        locale_info->grouping = "\3"; /* Group every 3 characters,
> +        locale_info->grouping = "\3\0"; /* Group every 3 characters,
>                                           trailing 0 means repeat
>                                           infinitely. */
>          break;
> _______________________________________________
> Python-checkins mailing list
> Python-checkins at python.org
> http://mail.python.org/mailman/listinfo/python-checkins
> 


-- 
Eric.


More information about the Python-checkins mailing list