[Python-checkins] r77562 - tracker/instances/python-dev/extensions/openid_login.py

martin.v.loewis python-checkins at python.org
Sun Jan 17 09:50:15 CET 2010


Author: martin.v.loewis
Date: Sun Jan 17 09:50:15 2010
New Revision: 77562

Log:
Report failed discoveries.


Modified:
   tracker/instances/python-dev/extensions/openid_login.py

Modified: tracker/instances/python-dev/extensions/openid_login.py
==============================================================================
--- tracker/instances/python-dev/extensions/openid_login.py	(original)
+++ tracker/instances/python-dev/extensions/openid_login.py	Sun Jan 17 09:50:15 2010
@@ -76,7 +76,10 @@
         type, claimed = openid.normalize_uri(username)
         if type == 'xri':
             raise ValueError, "XRIs are not supported"
-        stypes, url, op_local = discovered = openid.discover(claimed)
+        discovered = openid.discover(claimed)
+        if not discovered:
+            raise ValueError, "OpenID provider discovery failed"
+        stypes, url, op_local = discovered
         session = self.get_session(claimed, discovered) # one session per claimed id
         realm = self.base+"?@action=openid_return"
         return_to = realm + "&__came_from=%s" % urllib.quote(self.client.path)


More information about the Python-checkins mailing list