[Python-checkins] r78507 - in python/branches/release31-maint: Lib/test/test_metaclass.py Misc/NEWS Python/bltinmodule.c

[benjamin.peterson]

Author: benjamin.peterson
Date: Sat Feb 27 18:56:22 2010
New Revision: 78507

Log:
Merged revisions 78505-78506 via svnmerge from 
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r78505 | benjamin.peterson | 2010-02-27 11:40:01 -0600 (Sat, 27 Feb 2010) | 1 line
  
  only accept AttributeError as indicating no __prepare__ attribute on a metaclass, allowing lookup errors to propogate
........
  r78506 | benjamin.peterson | 2010-02-27 11:41:13 -0600 (Sat, 27 Feb 2010) | 1 line
  
  check PyDict_New() for error
........


Modified:
   python/branches/release31-maint/   (props changed)
   python/branches/release31-maint/Lib/test/test_metaclass.py
   python/branches/release31-maint/Misc/NEWS
   python/branches/release31-maint/Python/bltinmodule.c

Modified: python/branches/release31-maint/Lib/test/test_metaclass.py
==============================================================================
--- python/branches/release31-maint/Lib/test/test_metaclass.py	(original)
+++ python/branches/release31-maint/Lib/test/test_metaclass.py	Sat Feb 27 18:56:22 2010
@@ -230,6 +230,20 @@
     42
     >>>
 
+Test failures in looking up the __prepare__ method work.
+    >>> class ObscureException(Exception):
+    ...     pass
+    >>> class FailDescr:
+    ...     def __get__(self, instance, owner):
+    ...        raise ObscureException
+    >>> class Meta(type):
+    ...     __prepare__ = FailDescr()
+    >>> class X(metaclass=Meta):
+    ...     pass
+    Traceback (most recent call last):
+    [...]
+    test.test_metaclass.ObscureException
+
 """
 
 __test__ = {'doctests' : doctests}

Modified: python/branches/release31-maint/Misc/NEWS
==============================================================================
--- python/branches/release31-maint/Misc/NEWS	(original)
+++ python/branches/release31-maint/Misc/NEWS	Sat Feb 27 18:56:22 2010
@@ -12,6 +12,8 @@
 Core and Builtins
 -----------------
 
+- Handle errors from looking up __prepare__ correctly.
+
 - Issue #5939: Add additional runtime checking to ensure a valid capsule
   in Modules/_ctypes/callproc.c.
 

Modified: python/branches/release31-maint/Python/bltinmodule.c
==============================================================================
--- python/branches/release31-maint/Python/bltinmodule.c	(original)
+++ python/branches/release31-maint/Python/bltinmodule.c	Sat Feb 27 18:56:22 2010
@@ -108,8 +108,16 @@
 	}
 	prep = PyObject_GetAttrString(meta, "__prepare__");
 	if (prep == NULL) {
-		PyErr_Clear();
-		ns = PyDict_New();
+		if (PyErr_ExceptionMatches(PyExc_AttributeError)) {
+			PyErr_Clear();
+			ns = PyDict_New();
+		}
+		else {
+			Py_DECREF(meta);
+			Py_XDECREF(mkw);
+			Py_DECREF(bases);
+			return NULL;
+		}
 	}
 	else {
 		PyObject *pargs = PyTuple_Pack(2, name, bases);
@@ -123,12 +131,12 @@
 		ns = PyEval_CallObjectWithKeywords(prep, pargs, mkw);
 		Py_DECREF(pargs);
 		Py_DECREF(prep);
-		if (ns == NULL) {
-			Py_DECREF(meta);
-			Py_XDECREF(mkw);
-			Py_DECREF(bases);
-			return NULL;
-		}
+	}
+	if (ns == NULL) {
+		Py_DECREF(meta);
+		Py_XDECREF(mkw);
+		Py_DECREF(bases);
+		return NULL;
 	}
 	cell = PyObject_CallFunctionObjArgs(func, ns, NULL);
 	if (cell != NULL) {