[Python-checkins] r78247 - in python/trunk: Lib/macpath.py Lib/ntpath.py Lib/os2emxpath.py Lib/posixpath.py Lib/test/test_macpath.py Lib/test/test_ntpath.py Lib/test/test_posixpath.py Misc/NEWS
ezio.melotti
python-checkins at python.org
Sat Feb 20 09:09:39 CET 2010
Author: ezio.melotti
Date: Sat Feb 20 09:09:39 2010
New Revision: 78247
Log:
#3426: os.path.abspath now returns unicode when its arg is unicode.
Modified:
python/trunk/Lib/macpath.py
python/trunk/Lib/ntpath.py
python/trunk/Lib/os2emxpath.py
python/trunk/Lib/posixpath.py
python/trunk/Lib/test/test_macpath.py
python/trunk/Lib/test/test_ntpath.py
python/trunk/Lib/test/test_posixpath.py
python/trunk/Misc/NEWS
Modified: python/trunk/Lib/macpath.py
==============================================================================
--- python/trunk/Lib/macpath.py (original)
+++ python/trunk/Lib/macpath.py Sat Feb 20 09:09:39 2010
@@ -186,7 +186,11 @@
def abspath(path):
"""Return an absolute path."""
if not isabs(path):
- path = join(os.getcwd(), path)
+ if isinstance(path, unicode):
+ cwd = os.getcwdu()
+ else:
+ cwd = os.getcwd()
+ path = join(cwd, path)
return normpath(path)
# realpath is a no-op on systems without islink support
Modified: python/trunk/Lib/ntpath.py
==============================================================================
--- python/trunk/Lib/ntpath.py (original)
+++ python/trunk/Lib/ntpath.py Sat Feb 20 09:09:39 2010
@@ -449,7 +449,11 @@
def abspath(path):
"""Return the absolute version of a path."""
if not isabs(path):
- path = join(os.getcwd(), path)
+ if isinstance(path, unicode):
+ cwd = os.getcwdu()
+ else:
+ cwd = os.getcwd()
+ path = join(cwd, path)
return normpath(path)
else: # use native Windows method on Windows
@@ -461,6 +465,8 @@
path = _getfullpathname(path)
except WindowsError:
pass # Bad path - return unchanged.
+ elif isinstance(path, unicode):
+ path = os.getcwdu()
else:
path = os.getcwd()
return normpath(path)
Modified: python/trunk/Lib/os2emxpath.py
==============================================================================
--- python/trunk/Lib/os2emxpath.py (original)
+++ python/trunk/Lib/os2emxpath.py Sat Feb 20 09:09:39 2010
@@ -146,7 +146,11 @@
def abspath(path):
"""Return the absolute version of a path"""
if not isabs(path):
- path = join(os.getcwd(), path)
+ if isinstance(path, unicode):
+ cwd = os.getcwdu()
+ else:
+ cwd = os.getcwd()
+ path = join(cwd, path)
return normpath(path)
# realpath is a no-op on systems without islink support
Modified: python/trunk/Lib/posixpath.py
==============================================================================
--- python/trunk/Lib/posixpath.py (original)
+++ python/trunk/Lib/posixpath.py Sat Feb 20 09:09:39 2010
@@ -337,7 +337,11 @@
def abspath(path):
"""Return an absolute path."""
if not isabs(path):
- path = join(os.getcwd(), path)
+ if isinstance(path, unicode):
+ cwd = os.getcwdu()
+ else:
+ cwd = os.getcwd()
+ path = join(cwd, path)
return normpath(path)
Modified: python/trunk/Lib/test/test_macpath.py
==============================================================================
--- python/trunk/Lib/test/test_macpath.py (original)
+++ python/trunk/Lib/test/test_macpath.py Sat Feb 20 09:09:39 2010
@@ -8,6 +8,16 @@
def test_abspath(self):
self.assertTrue(macpath.abspath("xx:yy") == "xx:yy")
+ # Issue 3426: check that abspath retuns unicode when the arg is unicode
+ # and str when it's str, with both ASCII and non-ASCII cwds
+ for cwd in (u'cwd', u'\xe7w\xf0'):
+ with test_support.temp_cwd(cwd):
+ for path in ('', 'foo', 'f\xf2\xf2', '/foo', 'C:\\'):
+ self.assertIsInstance(macpath.abspath(path), str)
+ for upath in (u'', u'fuu', u'f\xf9\xf9', u'/fuu', u'U:\\'):
+ self.assertIsInstance(macpath.abspath(upath), unicode)
+
+
def test_isabs(self):
isabs = macpath.isabs
self.assertTrue(isabs("xx:yy"))
Modified: python/trunk/Lib/test/test_ntpath.py
==============================================================================
--- python/trunk/Lib/test/test_ntpath.py (original)
+++ python/trunk/Lib/test/test_ntpath.py Sat Feb 20 09:09:39 2010
@@ -160,13 +160,25 @@
# the rest of the tests for the ntpath module to be run to completion
# on any platform, since most of the module is intended to be usable
# from any platform.
+ # XXX this needs more tests
try:
import nt
except ImportError:
- pass
+ # check that the function is there even if we are not on Windows
+ ntpath.abspath
else:
tester('ntpath.abspath("C:\\")', "C:\\")
+ # Issue 3426: check that abspath retuns unicode when the arg is
+ # unicode and str when it's str, with both ASCII and non-ASCII cwds
+ for cwd in (u'cwd', u'\xe7w\xf0'):
+ with test_support.temp_cwd(cwd):
+ for path in ('', 'foo', 'f\xf2\xf2', '/foo', 'C:\\'):
+ self.assertIsInstance(ntpath.abspath(path), str)
+ for upath in (u'', u'fuu', u'f\xf9\xf9', u'/fuu', u'U:\\'):
+ self.assertIsInstance(ntpath.abspath(upath), unicode)
+
+
def test_relpath(self):
currentdir = os.path.split(os.getcwd())[-1]
tester('ntpath.relpath("a")', 'a')
Modified: python/trunk/Lib/test/test_posixpath.py
==============================================================================
--- python/trunk/Lib/test/test_posixpath.py (original)
+++ python/trunk/Lib/test/test_posixpath.py Sat Feb 20 09:09:39 2010
@@ -386,6 +386,15 @@
def test_abspath(self):
self.assertTrue("foo" in posixpath.abspath("foo"))
+ # Issue 3426: check that abspath retuns unicode when the arg is unicode
+ # and str when it's str, with both ASCII and non-ASCII cwds
+ for cwd in (u'cwd', u'\xe7w\xf0'):
+ with test_support.temp_cwd(cwd):
+ for path in ('', 'foo', 'f\xf2\xf2', '/foo', 'C:\\'):
+ self.assertIsInstance(posixpath.abspath(path), str)
+ for upath in (u'', u'fuu', u'f\xf9\xf9', u'/fuu', u'U:\\'):
+ self.assertIsInstance(posixpath.abspath(upath), unicode)
+
self.assertRaises(TypeError, posixpath.abspath)
def test_realpath(self):
Modified: python/trunk/Misc/NEWS
==============================================================================
--- python/trunk/Misc/NEWS (original)
+++ python/trunk/Misc/NEWS Sat Feb 20 09:09:39 2010
@@ -15,6 +15,8 @@
Library
-------
+- Issue #3426: ``os.path.abspath`` now returns unicode when its arg is unicode.
+
- Issue #7633: In the decimal module, Context class methods (with the
exception of canonical and is_canonical) now accept instances of int
and long wherever a Decimal instance is accepted, and implicitly
@@ -28,7 +30,7 @@
argument added to the TextTestRunner constructor allowing a different result
class to be used without having to subclass.
-- Issue 7588: ``unittest.TextTestResult.getDescription`` now includes the test
+- Issue #7588: ``unittest.TextTestResult.getDescription`` now includes the test
name in failure reports even if the test has a docstring.
Extension Modules
More information about the Python-checkins
mailing list