[Python-checkins] r77967 - in python/trunk: Lib/logging/config.py Lib/test/test_logging.py Misc/NEWS

A.M. Kuchling amk at amk.ca
Thu Feb 4 20:25:14 CET 2010


On Thu, Feb 04, 2010 at 10:49:06AM -0800, vinay.sajip wrote:
> @@ -64,6 +65,7 @@
>      """
>      import ConfigParser
>  
> +    print >> open('/tmp/tmp.txt', 'w'), fname.getvalue()
>      cp = ConfigParser.ConfigParser(defaults)
>      if hasattr(cp, 'readfp') and hasattr(fname, 'readline'):
>          cp.readfp(fname)

This looks like debugging code.

> +            if type(result) in (ConvertingDict, ConvertingList,
> +                                ConvertingTuple):

Can you use isinstance() here, or does Python version compatibility
rule that out?  (I don't remember what logging tries to support.)

--amk


More information about the Python-checkins mailing list