[Python-checkins] r80166 - python/trunk/Lib/platform.py

[Victor Stinner]

Le dimanche 18 avril 2010 13:35:16, M.-A. Lemburg a écrit :
> > New Revision: 80166
> > ...
> > platform: use subprocess.Popen() instead of os.popen() in _syscmd_file()
> > ...
> 
> Viktor, before making such changes to platform.py, please coordinate
> with me, as I am the maintainer of that module.

I didn't know that platform is a special module (used in the build process), 
nor that your are the maintainer.

> The subprocess change is not OK, since platform.py has to stay
> compatible with Python 2.3 which doesn't have subprocess. Please either
> revert the change or make it fallback to os.popen().

First I wrote my patch for py3k, but then I realized that it would be better 
to have the same code in both branches (trunk and py3k). In py3k, os.popen() 
is based on subprocess. Fail. It wasn't a good idea :-)

Sorry for breaking both branches. I reverted my both patches. I will maybe 
open an issue to retry a patch on py3k.

--

My patch works on py3k, even for the build bootstrap. But I don't understand 
how it could work since _posixsubprocess is not a builtin module :-)

-- 
Victor Stinner
http://www.haypocalc.com/