[Python-checkins] r67257 - sandbox/trunk/tkinter-polo/src/SimpleDialog.py

guilherme.polo python-checkins at python.org
Tue Nov 18 13:00:39 CET 2008


Author: guilherme.polo
Date: Tue Nov 18 13:00:38 2008
New Revision: 67257

Log:
* Removed usage of star import;
* SimpleDialog is subclass of Toplevel now;
* Changed its layout a bit, added some spacing, buttons on the right;
* Removed the _set_transient method: didn't see the need to do such geometry
  tricks;
* Moved the example in the bottom to an example method


Modified:
   sandbox/trunk/tkinter-polo/src/SimpleDialog.py

Modified: sandbox/trunk/tkinter-polo/src/SimpleDialog.py
==============================================================================
--- sandbox/trunk/tkinter-polo/src/SimpleDialog.py	(original)
+++ sandbox/trunk/tkinter-polo/src/SimpleDialog.py	Tue Nov 18 13:00:38 2008
@@ -1,112 +1,84 @@
 """A simple but flexible modal dialog box."""
 
+__all__ = ['SimpleDialog']
 
-from Tkinter import *
+from Tkinter import Toplevel, Label, Frame, Message, Button
+from Tkconstants import BOTH, LEFT, RIGHT
 
-
-class SimpleDialog:
-
-    def __init__(self, master,
-                 text='', buttons=[], default=None, cancel=None,
-                 title=None, class_=None):
-        if class_:
-            self.root = Toplevel(master, class_=class_)
-        else:
-            self.root = Toplevel(master)
-        if title:
-            self.root.title(title)
-            self.root.iconname(title)
-        self.message = Message(self.root, text=text, aspect=400)
-        self.message.pack(expand=1, fill=BOTH)
-        self.frame = Frame(self.root)
-        self.frame.pack()
+class SimpleDialog(Toplevel):
+    def __init__(self, master=None, text='', buttons=None, default=None,
+                 cancel=None,  title=None, **kw):
+        Toplevel.__init__(self, master, **kw)
+        self.wm_title(title)
+        self.wm_iconname(title)
+
+        spacing = {'padx': 6, 'pady': 6}
+        self.message = Message(self, text=text, aspect=400)
+        self.message.pack(expand=True, fill=BOTH, **spacing)
+        self.frame = Frame(self)
+        self.frame.pack(side=RIGHT)
         self.num = default
         self.cancel = cancel
         self.default = default
-        self.root.bind('<Return>', self.return_event)
-        for num in range(len(buttons)):
-            s = buttons[num]
-            b = Button(self.frame, text=s,
-                       command=(lambda self=self, num=num: self.done(num)))
-            if num == default:
-                b.config(relief=RIDGE, borderwidth=8)
-            b.pack(side=LEFT, fill=BOTH, expand=1)
-        self.root.protocol('WM_DELETE_WINDOW', self.wm_delete_window)
-        self._set_transient(master)
-
-    def _set_transient(self, master, relx=0.5, rely=0.3):
-        widget = self.root
-        widget.withdraw() # Remain invisible while we figure out the geometry
-        widget.transient(master)
-        widget.update_idletasks() # Actualize geometry information
-        if master.winfo_ismapped():
-            m_width = master.winfo_width()
-            m_height = master.winfo_height()
-            m_x = master.winfo_rootx()
-            m_y = master.winfo_rooty()
-        else:
-            m_width = master.winfo_screenwidth()
-            m_height = master.winfo_screenheight()
-            m_x = m_y = 0
-        w_width = widget.winfo_reqwidth()
-        w_height = widget.winfo_reqheight()
-        x = m_x + (m_width - w_width) * relx
-        y = m_y + (m_height - w_height) * rely
-        if x+w_width > master.winfo_screenwidth():
-            x = master.winfo_screenwidth() - w_width
-        elif x < 0:
-            x = 0
-        if y+w_height > master.winfo_screenheight():
-            y = master.winfo_screenheight() - w_height
-        elif y < 0:
-            y = 0
-        widget.geometry("+%d+%d" % (x, y))
-        widget.deiconify() # Become visible at the desired location
+        self.bind('<Return>', self.return_event)
+
+        buttons = buttons or ()
+        for indx, text in enumerate(buttons):
+            b = Button(self.frame, text=text,
+                       command=(lambda self=self, indx=indx: self.done(indx)))
+            b.pack(side=RIGHT, **spacing)
+            if indx == default:
+                b.config(default='active')
+
+        self.wm_protocol('WM_DELETE_WINDOW', self.wm_delete_window)
+        self.wm_transient(master)
 
     def go(self):
-        self.root.wait_visibility()
-        self.root.grab_set()
-        self.root.mainloop()
-        self.root.destroy()
+        self.wait_visibility()
+        self.grab_set()
+        self.mainloop()
+        self.destroy()
         return self.num
 
     def return_event(self, event):
         if self.default is None:
-            self.root.bell()
+            self.bell()
         else:
             self.done(self.default)
 
     def wm_delete_window(self):
         if self.cancel is None:
-            self.root.bell()
+            self.bell()
         else:
             self.done(self.cancel)
 
     def done(self, num):
         self.num = num
-        self.root.quit()
+        self.quit()
 
 
-if __name__ == '__main__':
+def example():
+    from Tkinter import Tk
 
-    def test():
-        root = Tk()
-        def doit(root=root):
-            d = SimpleDialog(root,
+    def show_dlg():
+        d = SimpleDialog(root,
                          text="This is a test dialog.  "
                               "Would this have been an actual dialog, "
                               "the buttons below would have been glowing "
                               "in soft pink light.\n"
-                              "Do you believe this?",
-                         buttons=["Yes", "No", "Cancel"],
+                              "Do you believe this ?",
+                         buttons=("Yes", "No", "Cancel"),
                          default=0,
                          cancel=2,
                          title="Test Dialog")
-            print d.go()
-        t = Button(root, text='Test', command=doit)
-        t.pack()
-        q = Button(root, text='Quit', command=t.quit)
-        q.pack()
-        t.mainloop()
+        print d.go()
 
-    test()
+    root = Tk()
+    t = Button(root, text='Test', command=show_dlg)
+    q = Button(root, text='Quit', command=t.quit)
+    t.pack()
+    q.pack()
+    root.mainloop()
+
+if __name__ == '__main__':
+    example()


More information about the Python-checkins mailing list