[Python-checkins] r63081 - sandbox/trunk/2to3/lib2to3/fixes/fix_imports.py

[Alexandre Vassalotti]

On Thu, May 15, 2008 at 1:46 PM, Collin Winter <collinw at gmail.com> wrote:
> On Sun, May 11, 2008 at 1:06 PM, alexandre.vassalotti
> <python-checkins at python.org> wrote:
>> Author: alexandre.vassalotti
>> Date: Sun May 11 22:06:36 2008
>> New Revision: 63081
>>
>> Log:
>> Added import fixer for Queue rename.
>
> You forgot a comma before 'Queue'. This indicates that you clearly
> didn't run the tests when you made this change, nor for any of the
> subsequent changes (if you had, it would have resulted in a
> SyntaxError). Do not check in code you haven't tested. 2to3 has a
> comprehensive test suite; use it.
>

Oh, sorry. I typically run the trunk's lib2to3 tests and then copy my
changes back to the sandbox. So, that is why I didn't see the missing
comma. Anyway, I admit this is bad practice from my part. By the way,
would it be a good idea to add specific test cases for the new import
fixes?

-- Alexandre