[Python-checkins] r60241 - in python/branches/release25-maint: Lib/ctypes/test/test_numbers.py Misc/NEWS Modules/_ctypes/cfield.c
thomas.heller
python-checkins at python.org
Thu Jan 24 14:08:55 CET 2008
Author: thomas.heller
Date: Thu Jan 24 14:08:54 2008
New Revision: 60241
Modified:
python/branches/release25-maint/Lib/ctypes/test/test_numbers.py
python/branches/release25-maint/Misc/NEWS
python/branches/release25-maint/Modules/_ctypes/cfield.c
Log:
Invert the checks in get_[u]long and get_[u]longlong. The intent was
to not accept float types; the result was that integer-like objects
were not accepted.
Modified: python/branches/release25-maint/Lib/ctypes/test/test_numbers.py
==============================================================================
--- python/branches/release25-maint/Lib/ctypes/test/test_numbers.py (original)
+++ python/branches/release25-maint/Lib/ctypes/test/test_numbers.py Thu Jan 24 14:08:54 2008
@@ -90,15 +90,31 @@
def test_floats(self):
# c_float and c_double can be created from
# Python int, long and float
+ class FloatLike(object):
+ def __float__(self):
+ return 2.0
+ f = FloatLike()
for t in float_types:
self.failUnlessEqual(t(2.0).value, 2.0)
self.failUnlessEqual(t(2).value, 2.0)
self.failUnlessEqual(t(2L).value, 2.0)
+ self.failUnlessEqual(t(f).value, 2.0)
def test_integers(self):
- # integers cannot be constructed from floats
+ class FloatLike(object):
+ def __float__(self):
+ return 2.0
+ f = FloatLike()
+ class IntLike(object):
+ def __int__(self):
+ return 2
+ i = IntLike()
+ # integers cannot be constructed from floats,
+ # but from integer-like objects
for t in signed_types + unsigned_types:
self.assertRaises(TypeError, t, 3.14)
+ self.assertRaises(TypeError, t, f)
+ self.failUnlessEqual(t(i).value, 2)
def test_sizes(self):
for t in signed_types + unsigned_types + float_types:
Modified: python/branches/release25-maint/Misc/NEWS
==============================================================================
--- python/branches/release25-maint/Misc/NEWS (original)
+++ python/branches/release25-maint/Misc/NEWS Thu Jan 24 14:08:54 2008
@@ -67,6 +67,9 @@
Library
-------
+- The ctypes int types did not accept objects implementing
+ __int__() in the constructor.
+
- #1189216: Fix the zipfile module to work on archives with headers
past the 2**31 byte boundary.
Modified: python/branches/release25-maint/Modules/_ctypes/cfield.c
==============================================================================
--- python/branches/release25-maint/Modules/_ctypes/cfield.c (original)
+++ python/branches/release25-maint/Modules/_ctypes/cfield.c Thu Jan 24 14:08:54 2008
@@ -355,10 +355,9 @@
get_long(PyObject *v, long *p)
{
long x;
- if (!PyInt_Check(v) && !PyLong_Check(v)) {
- PyErr_Format(PyExc_TypeError,
- "int expected instead of %s instance",
- v->ob_type->tp_name);
+ if (PyFloat_Check(v)) {
+ PyErr_SetString(PyExc_TypeError,
+ "int expected instead of float");
return -1;
}
x = PyInt_AsUnsignedLongMask(v);
@@ -374,10 +373,9 @@
get_ulong(PyObject *v, unsigned long *p)
{
unsigned long x;
- if (!PyInt_Check(v) && !PyLong_Check(v)) {
- PyErr_Format(PyExc_TypeError,
- "int expected instead of %s instance",
- v->ob_type->tp_name);
+ if (PyFloat_Check(v)) {
+ PyErr_SetString(PyExc_TypeError,
+ "int expected instead of float");
return -1;
}
x = PyInt_AsUnsignedLongMask(v);
@@ -395,11 +393,10 @@
get_longlong(PyObject *v, PY_LONG_LONG *p)
{
PY_LONG_LONG x;
- if (!PyInt_Check(v) && !PyLong_Check(v)) {
- PyErr_Format(PyExc_TypeError,
- "int expected instead of %s instance",
- v->ob_type->tp_name);
- return -1;
+ if (PyFloat_Check(v)) {
+ PyErr_SetString(PyExc_TypeError,
+ "int expected instead of float");
+ return -1;
}
x = PyInt_AsUnsignedLongLongMask(v);
if (x == -1 && PyErr_Occurred())
@@ -414,12 +411,11 @@
get_ulonglong(PyObject *v, unsigned PY_LONG_LONG *p)
{
unsigned PY_LONG_LONG x;
- if (!PyInt_Check(v) && !PyLong_Check(v)) {
- PyErr_Format(PyExc_TypeError,
- "int expected instead of %s instance",
- v->ob_type->tp_name);
- return -1;
- }
+ if (PyFloat_Check(v)) {
+ PyErr_SetString(PyExc_TypeError,
+ "int expected instead of float");
+ return -1;
+ }
x = PyInt_AsUnsignedLongLongMask(v);
if (x == -1 && PyErr_Occurred())
return -1;
More information about the Python-checkins
mailing list