[Python-checkins] r67923 - in python/trunk: Lib/io.py Lib/test/test_io.py Misc/NEWS

[benjamin.peterson]

Author: benjamin.peterson
Date: Wed Dec 24 16:10:27 2008
New Revision: 67923

Log:
#4736 BufferRWPair.closed shouldn't try to call another property as a function

Modified:
   python/trunk/Lib/io.py
   python/trunk/Lib/test/test_io.py
   python/trunk/Misc/NEWS

Modified: python/trunk/Lib/io.py
==============================================================================
--- python/trunk/Lib/io.py	(original)
+++ python/trunk/Lib/io.py	Wed Dec 24 16:10:27 2008
@@ -1167,7 +1167,7 @@
 
     @property
     def closed(self):
-        return self.writer.closed()
+        return self.writer.closed
 
 
 class BufferedRandom(BufferedWriter, BufferedReader):

Modified: python/trunk/Lib/test/test_io.py
==============================================================================
--- python/trunk/Lib/test/test_io.py	(original)
+++ python/trunk/Lib/test/test_io.py	Wed Dec 24 16:10:27 2008
@@ -554,8 +554,9 @@
         r = MockRawIO(())
         w = MockRawIO()
         pair = io.BufferedRWPair(r, w)
+        self.assertFalse(pair.closed)
 
-        # XXX need implementation
+        # XXX More Tests
 
 
 class BufferedRandomTest(unittest.TestCase):

Modified: python/trunk/Misc/NEWS
==============================================================================
--- python/trunk/Misc/NEWS	(original)
+++ python/trunk/Misc/NEWS	Wed Dec 24 16:10:27 2008
@@ -86,6 +86,8 @@
 Library
 -------
 
+- Issue #4736: io.BufferedRWPair's closed property now functions properly.
+
 - Issue #3954: Fix a potential SystemError in _hotshot.logreader error
   handling.