[Python-checkins] r57747 - python/trunk/Tools/msi/msilib.py

martin.v.loewis python-checkins at python.org
Thu Aug 30 20:14:02 CEST 2007


Author: martin.v.loewis
Date: Thu Aug 30 20:14:01 2007
New Revision: 57747

Modified:
   python/trunk/Tools/msi/msilib.py
Log:
Fix popen usage.

Modified: python/trunk/Tools/msi/msilib.py
==============================================================================
--- python/trunk/Tools/msi/msilib.py	(original)
+++ python/trunk/Tools/msi/msilib.py	Thu Aug 30 20:14:01 2007
@@ -390,8 +390,8 @@
             cabarc = "cabarc.exe"
         cmd = r'"%s" -m lzx:21 n %s.cab @%s.txt' % (cabarc, self.name, self.name)
         p = subprocess.Popen(cmd, shell=True, stdin=subprocess.PIPE,
-                             stdout=subprocess.PIPE, stderr=subprocess.STDOUT)[0]
-        for line in (p.stdout, p.stdin):
+                             stdout=subprocess.PIPE, stderr=subprocess.STDOUT)
+        for line in p.stdout:
             if line.startswith("  -- adding "):
                 sys.stdout.write(".")
             else:


More information about the Python-checkins mailing list