[Python-checkins] r52030 - in python/branches/release24-maint: Misc/NEWS Modules/posixmodule.c

[Michael Hudson]

"andrew.kuchling" <python-checkins at python.org> writes:

> Author: andrew.kuchling
> Date: Thu Sep 28 19:16:25 2006
> New Revision: 52030
>
> Modified:
>    python/branches/release24-maint/Misc/NEWS
>    python/branches/release24-maint/Modules/posixmodule.c
> Log:
> [Backport rev. 39135 by mwh]
>
> Fix bug
>
> [ 1232517 ] OverflowError in time.utime() causes strange traceback
>
> A needed error check was missing.
>
> (Actually, this error check may only have become necessary in fairly
> recent Python, not sure).
>
> Backport candidate.
>
> [A few lines below the code in 2.4 touched by the patch, there's already 
>  a similar check of (intval == -1 && PyErr_Occurred()), so I think 
>  this function can already report such errors, and therefore the fix
>  still applies.  Perhaps Michael can clarify what he was referring to. --amk]

I think what changed to prompt the "only recent Python" comment was
that int(some large float) returns a long, rather than raising an
error by itself.  This change is in 2.4 (it seems to be a 2.2->2.3
change) so this is indeed a valid back port.  Thanks!

Cheers,
mwh

-- 
  On the other hand, the following areas are subject to boycott
  in reaction to the rampant impurity of design or execution, as
  determined after a period of study, in no particular order:
    ...                              http://www.naggum.no/profile.html