[Python-checkins] r52096 - in python/branches/release24-maint: Misc/NEWS Objects/cellobject.c

[andrew.kuchling]

Author: andrew.kuchling
Date: Tue Oct  3 14:58:52 2006
New Revision: 52096

Modified:
   python/branches/release24-maint/Misc/NEWS
   python/branches/release24-maint/Objects/cellobject.c
Log:
[Backport rev. 47171 by neal.norwitz]

Another problem reported by Coverity.  Backport candidate.


Modified: python/branches/release24-maint/Misc/NEWS
==============================================================================
--- python/branches/release24-maint/Misc/NEWS	(original)
+++ python/branches/release24-maint/Misc/NEWS	Tue Oct  3 14:58:52 2006
@@ -25,7 +25,7 @@
 - Overflow checking code in integer division ran afoul of new gcc
   optimizations.  Changed to be more standard-conforming.
 
-- Fix warnings reported by Klocwork's static analysis tool.
+- Fix warnings reported by the Coverity and Klocwork static analysis tools.
 
 - Patch #1541585: fix buffer overrun when performing repr() on
   a unicode string in a build with wide unicode (UCS-4) support.

Modified: python/branches/release24-maint/Objects/cellobject.c
==============================================================================
--- python/branches/release24-maint/Objects/cellobject.c	(original)
+++ python/branches/release24-maint/Objects/cellobject.c	Tue Oct  3 14:58:52 2006
@@ -8,6 +8,8 @@
 	PyCellObject *op;
 
 	op = (PyCellObject *)PyObject_GC_New(PyCellObject, &PyCell_Type);
+	if (op == NULL)
+		return NULL;
 	op->ob_ref = obj;
 	Py_XINCREF(obj);