[Python-checkins] r46247 - in python/branches/sreifschneider-newnewexcept: Makefile.pre.in Objects/exceptions.c Python/exceptions.c

[Jim Jewett]

On 5/25/06, richard.jones <python-checkins at python.org> wrote:
> Author: richard.jones
> Date: Thu May 25 21:43:03 2006
> New Revision: 46247
>
> Removed:
>    python/branches/sreifschneider-newnewexcept/Python/exceptions.c
> Modified:
>    python/branches/sreifschneider-newnewexcept/Makefile.pre.in
>    python/branches/sreifschneider-newnewexcept/Objects/exceptions.c
> Log:
> Transitioning Exceptions over to being PyTypeObjects rather than
> faked-class PyObjects.
>
> Doesn't currently work - this is just to checkpoint that the bulk of the
> work has been done and now we're debugging.

> Modified: python/branches/sreifschneider-newnewexcept/Objects/exceptions.c
> ==============================================================================
> --- python/branches/sreifschneider-newnewexcept/Objects/exceptions.c    (original)
> +++ python/branches/sreifschneider-newnewexcept/Objects/exceptions.c    Thu May 25 21:43:03 2006
> @@ -65,55 +69,31 @@
>
>  #ifdef Py_USING_UNICODE
>  static PyObject *
> -BaseException_unicode(PyObject *self, PyObject *args)
> +BaseException_unicode(BaseExceptionObject *self, PyObject *args)
>  {

...

> +        PyObject *temp = PySequence_GetItem(self->args, 0);
> +        PyObject *unicode_obj;

Do these have to go in the other order, because of a C89 requirement
about declarations before operations?

> +/*
> + *    OverflowWarning extends Warning
> + */
> +SimpleExtendsException(PyExc_Warning, OverflowWarning, "Base class for warnings about numeric overflow.  Won't exist in Python 2.5.");

Take it out now?

-jJ