[Python-checkins] r50503 - python/trunk/Lib/tarfile.py

neal.norwitz python-checkins at python.org
Mon Jul 10 02:23:18 CEST 2006


Author: neal.norwitz
Date: Mon Jul 10 02:23:17 2006
New Revision: 50503

Modified:
   python/trunk/Lib/tarfile.py
Log:
Part of SF patch #1484695.  This removes dead code.  The chksum was
already verified in .frombuf() on the lines above.  If there was
a problem an exception is raised, so there was no way this condition
could have been true.


Modified: python/trunk/Lib/tarfile.py
==============================================================================
--- python/trunk/Lib/tarfile.py	(original)
+++ python/trunk/Lib/tarfile.py	Mon Jul 10 02:23:17 2006
@@ -1750,13 +1750,6 @@
             try:
                 tarinfo = TarInfo.frombuf(buf)
 
-                # We shouldn't rely on this checksum, because some tar programs
-                # calculate it differently and it is merely validating the
-                # header block. We could just as well skip this part, which would
-                # have a slight effect on performance...
-                if tarinfo.chksum not in calc_chksums(buf):
-                    self._dbg(1, "tarfile: Bad Checksum %r" % tarinfo.name)
-
                 # Set the TarInfo object's offset to the current position of the
                 # TarFile and set self.offset to the position where the data blocks
                 # should begin.


More information about the Python-checkins mailing list