[Python-checkins] r42012 - in python/trunk: Lib/test/output/test_mmap Lib/test/test_mmap.py Misc/ACKS Misc/NEWS Modules/mmapmodule.c

[Neal Norwitz]

On 1/11/06, Georg Brandl <g.brandl-nospam at gmx.net> wrote:
>
> You didn't fix the other problem, that dup() mustn't be called
> when the fd is -1, cause it errors out then.
>
> So either we check for -1 or for MAP_ANON.

Right, that seems like a feature enhancement.  If you pass -1 now, an
exception is raised rather than a crash. I didn't see anything in the
docs which say we support -1 for anon maps.

I mentioned it in the bug report that it would be better to open a new
patch with the code to add this feature for both unix and windows (not
sure how Windows works) and also update the doc.  I should have
mentioned that he should add a test too.

n