[Python-checkins] commit of r41907 - python/trunk/Makefile.pre.in

[Sjoerd Mullender]

Neal Norwitz wrote:
> This change broke on Solaris 10.
> 
> http://www.python.org/dev/buildbot/sparc%20solaris10%20gcc%20trunk/builds/48/step-compile/0
> 
> make: Fatal error: Command failed for target `buildno'

The program "type" is not portable: it's a bash-ism.

> n
> --
> 
> On 1/3/06, barry.warsaw <python-checkins at python.org> wrote:
> 
>>Author: barry.warsaw
>>Date: Tue Jan  3 15:30:55 2006
>>New Revision: 41907
>>
>>Modified:
>>   python/trunk/Makefile.pre.in
>>Log:
>>SF bug #1395926: Also test for svnversion command on $PATH before using it to
>>calculate the build number.
>>
>>
>>Modified: python/trunk/Makefile.pre.in
>>==============================================================================
>>--- python/trunk/Makefile.pre.in        (original)
>>+++ python/trunk/Makefile.pre.in        Tue Jan  3 15:30:55 2006
>>@@ -349,7 +349,7 @@
>>                $(SIGNAL_OBJS) \
>>                $(MODOBJS) \
>>                $(srcdir)/Modules/getbuildinfo.c
>>-       if test -d $(srcdir)/.svn; then \
>>+       if test -d $(srcdir)/.svn -a ! -z "`type -t svnversion`" ; then \
>>                svnversion $(srcdir) >buildno; \
>>        elif test -f buildno; then \
>>                expr `cat buildno` + 1 >buildno1; \
>>_______________________________________________
>>Python-checkins mailing list
>>Python-checkins at python.org
>>http://mail.python.org/mailman/listinfo/python-checkins
>>
> 
> _______________________________________________
> Python-checkins mailing list
> Python-checkins at python.org
> http://mail.python.org/mailman/listinfo/python-checkins


-- 
Sjoerd Mullender
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 369 bytes
Desc: OpenPGP digital signature
Url : http://mail.python.org/pipermail/python-checkins/attachments/20060104/83e8494e/attachment.pgp